Merge pull request #6 from trailheadapps/pozil/flow-fixes

fix: flow test and flow SFCA fixes

Author: muenzpraeger

.github/workflows/ci-pr.yml

@@ -79,7 +79,7 @@ jobs:
               id: run-code-analyzer
               uses: forcedotcom/run-code-analyzer@v2
               with:
-                  run-arguments: --workspace "force-app/**" --view detail --output-file "sca-results.csv" --config-file "code-analyzer.yml"
+                  run-arguments: --workspace "force-app/main" --view detail --output-file "sca-results.csv" --config-file "code-analyzer.yml"
                   results-artifact-name: code-analyzer-results
                   github-token: ${{ github.token }}
 

.github/workflows/ci.yml

@@ -62,7 +62,7 @@ jobs:
               id: run-code-analyzer
               uses: forcedotcom/run-code-analyzer@v2
               with:
-                  run-arguments: --workspace "force-app/**" --view detail --output-file "sca-results.csv" --config-file "code-analyzer.yml"
+                  run-arguments: --workspace "force-app/main" --view detail --output-file "sca-results.csv" --config-file "code-analyzer.yml"
                   results-artifact-name: code-analyzer-results
                   github-token: ${{ github.token }}
 

code-analyzer.yml

@@ -1,6 +1,12 @@
-engines:
+rules:
     flow:
-        disable_engine: true
+        # Disabled HardCodedId rule for flow as a temporary workaround for
+        # https://github.com/forcedotcom/code-analyzer/issues/1947
+        HardCodedId:
+            severity: Critical
+            tags: []
+
+engines:
     eslint:
         auto_discover_eslint_config: true
         disable_javascript_base_config: true

force-app/main/02_actionConfiguration/actionDescriptionOverrides/classes/ActionDescriptionOverridesFlowTest.cls

@@ -52,9 +52,11 @@ private class ActionDescriptionOverridesFlowTest {
         // Set input variables for the flow
         Map<String, Object> inputs = new Map<String, Object>();
         inputs.put('report_type', 'Sales Report');
-        inputs.put('start_date', Date.newInstance(2024, 1, 1));
-        inputs.put('end_date', Date.newInstance(2024, 12, 31));
         inputs.put('include_charts', true);
+        inputs.put('user_id', UserInfo.getUserId());
+        inputs.put('format', 'PDF');
+        inputs.put('start_date', '2024-01-01');
+        inputs.put('end_date', '2024-12-31');
 
         // Run the flow
         Test.startTest();

package.json

@@ -10,6 +10,7 @@
         "url": "git+https://github.com/trailheadapps/agent-script-recipes"
     },
     "scripts": {
+        "code-analyzer": "sf code-analyzer run --workspace force-app/main --view detail --output-file \"sca-results.csv\" --config-file \"code-analyzer.yml\"",
         "lint": "eslint .",
         "test": "npm run test:unit",
         "test:unit": "sfdx-lwc-jest",