fix: Correct privacy template test - use privacy-logrotate.j2 not 99-privacy-enhanced.j2

## Issue Resolution

### Template Name Confusion Fixed
- **Problem**: Test expected `99-privacy-enhanced.j2` template (which shouldn't exist)
- **Reality**: Task uses `privacy-logrotate.j2` template to create `/etc/logrotate.d/99-privacy-enhanced` file
- **Solution**: Updated test to use correct template name `privacy-logrotate.j2`

### Implementation Details
- **✅ Correct Flow**: `privacy-logrotate.j2` → `/etc/logrotate.d/99-privacy-enhanced`
- **❌ Wrong Expectation**: Looking for `99-privacy-enhanced.j2` template file
- **✅ Fixed**: Test now validates the actual template that creates the logrotate config

### Enhanced Test Coverage
- **Added privacy-logrotate.j2** to active template tests
- **Updated test variables** with missing logrotate parameters:
  - `rotate_count: 3`
  - `daily_rotation: True`
- **Added proper validation** for logrotate template content:
  - Rotation count configuration
  - Max age settings
  - Syslog rotation rules

### Why This Matters
The original question "Why is this intentionally unimplemented?" was correct - there was no good reason for the template to be missing. The actual issue was:

1. **The template exists** (`privacy-logrotate.j2`)
2. **The test was wrong** (looking for non-existent `99-privacy-enhanced.j2`)
3. **The functionality works** (creates `/etc/logrotate.d/99-privacy-enhanced` correctly)

## Test Results
- ✅ **4/4 privacy tests passing**
- ✅ **Complete template coverage** for all implemented privacy templates
- ✅ **Proper logrotate validation** with realistic test parameters

This resolves the template gap feedback completely - all privacy templates that should exist are now properly tested.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: dguido

tests/unit/test_privacy_role.py

@@ -27,7 +27,9 @@ def get_privacy_test_variables():
         'privacy_log_rotation': {
             'max_age': 7,
             'max_size': 50,
-            'compress': True
+            'compress': True,
+            'rotate_count': 3,
+            'daily_rotation': True
         },
         'privacy_log_filtering': {
             'exclude_vpn_logs': True,
@@ -111,9 +113,8 @@ def test_privacy_template_rendering():
     privacy_templates = [
         'roles/privacy/templates/49-privacy-vpn-filter.conf.j2',
         'roles/privacy/templates/privacy-monitor.sh.j2',
-        'roles/privacy/templates/privacy-auto-cleanup.sh.j2',  # Now implemented
-        # Skip templates that don't exist yet
-        # 'roles/privacy/templates/99-privacy-enhanced.j2',
+        'roles/privacy/templates/privacy-auto-cleanup.sh.j2',
+        'roles/privacy/templates/privacy-logrotate.j2',  # Creates /etc/logrotate.d/99-privacy-enhanced
     ]
 
     test_vars = get_privacy_test_variables()
@@ -157,9 +158,11 @@ def test_privacy_template_rendering():
                 if test_vars['privacy_auto_cleanup']['enabled']:
                     assert 'Starting privacy cleanup' in output, "Missing cleanup start message"
 
-            elif '99-privacy-enhanced.j2' in template_name:
-                # Should contain logrotate configuration
-                assert 'daily' in output or 'weekly' in output, "Missing rotation frequency"
+            elif 'privacy-logrotate.j2' in template_name:
+                # Should contain logrotate configuration  
+                assert 'rotate' in output, "Missing rotation count"
+                assert 'maxage' in output, "Missing max age configuration"
+                assert '/var/log/syslog' in output, "Missing syslog rotation"
 
         except UndefinedError as e:
             errors.append(f"{template_path}: Missing variable - {e}")