Fix AWS Lightsail deployment error (boto3 parameter) (#14823)

* Fix AWS Lightsail deployment error by removing deprecated boto3 parameter

Remove the deprecated boto3 parameter from get_aws_connection_info() call
in the lightsail_region_facts module. This parameter has been non-functional
since amazon.aws collection 4.0.0 and was removed in recent versions bundled
with Ansible 11.x, causing deployment failures.

The function works correctly without this parameter as the module already
properly imports and validates boto3 availability.

Closes #14822

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update uv.lock to fix Docker build failure

The lockfile was out of sync after the Ansible 11.8.0 to 11.9.0 upgrade.
This regenerates the lockfile to include:
- ansible 11.9.0 (was 11.8.0)
- ansible-core 2.18.8 (was 2.18.7)

This fixes the Docker build CI failure where uv sync --locked was failing
due to lockfile mismatch.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Fix Jinja spacing linter issues correctly

- Add spacing in lookup('env', 'VAR') calls
- Fix spacing around pipe operators within Jinja expressions only
- Preserve YAML block scalar syntax (prompt: |)
- Fix array indexing spacing within Jinja expressions
- All changes pass yamllint and ansible-lint tests

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Add algo.egg-info to .gitignore

* Add unit test for AWS Lightsail boto3 parameter fix

- Tests that get_aws_connection_info() is called without boto3 parameter
- Verifies the module can be imported successfully
- Checks source code doesn't contain boto3=True
- Regression test specifically for issue #14822
- All 4 test cases pass

This ensures the fix remains in place and prevents regression.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Fix Python linting issues in test file

- Sort imports according to ruff standards
- Remove trailing whitespace from blank lines
- Remove unnecessary 'r' mode argument from open()
- Add trailing newline at end of file

All tests still pass after linting fixes.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>

Author: dguido

.gitignore

@@ -10,3 +10,4 @@ inventory_users
 .ansible/
 __pycache__/
 *.pyc
+algo.egg-info/

input.yml

@@ -42,7 +42,7 @@
 
         - name: Set facts based on the input
           set_fact:
-            algo_provider: "{{ provider | default(providers_map[_algo_provider.user_input|default(omit)|int - 1]['alias']) }}"
+            algo_provider: "{{ provider | default(providers_map[_algo_provider.user_input | default(omit) | int - 1]['alias']) }}"
 
         - name: VPN server name prompt
           pause:
@@ -110,10 +110,10 @@
           set_fact:
             algo_server_name: >-
               {% if server_name is defined %}{% set _server = server_name %}
-              {%- elif _algo_server_name.user_input is defined and _algo_server_name.user_input|length > 0 -%}
+              {%- elif _algo_server_name.user_input is defined and _algo_server_name.user_input | length > 0 -%}
               {%- set _server = _algo_server_name.user_input -%}
               {%- else %}{% set _server = defaults['server_name'] %}{% endif -%}
-              {{ _server | regex_replace('(?!\.)(\W|_)', '-') }}
+              {{ _server | regex_replace('(?!\.)(\W | _)', '-') }}
             algo_ondemand_cellular: >-
               {% if ondemand_cellular is defined %}{{ ondemand_cellular | bool }}
               {%- elif _ondemand_cellular.user_input is defined %}{{ booleans_map[_ondemand_cellular.user_input] | default(defaults['ondemand_cellular']) }}
@@ -124,7 +124,7 @@
               {%- else %}false{% endif %}
             algo_ondemand_wifi_exclude: >-
               {% if ondemand_wifi_exclude is defined %}{{ ondemand_wifi_exclude | b64encode }}
-              {%- elif _ondemand_wifi_exclude.user_input is defined and _ondemand_wifi_exclude.user_input|length > 0 -%}
+              {%- elif _ondemand_wifi_exclude.user_input is defined and _ondemand_wifi_exclude.user_input | length > 0 -%}
               {{ _ondemand_wifi_exclude.user_input | b64encode }}
               {%- else %}{{ '_null' | b64encode }}{% endif %}
             algo_dns_adblocking: >-

library/lightsail_region_facts.py

@@ -82,7 +82,7 @@ def main():
         module.fail_json(msg='Python module "botocore" is missing, please install it')
 
     try:
-        region, ec2_url, aws_connect_kwargs = get_aws_connection_info(module, boto3=True)
+        region, ec2_url, aws_connect_kwargs = get_aws_connection_info(module)
 
         client = None
         try:

playbooks/cloud-post.yml

@@ -8,8 +8,8 @@
     name: "{% if cloud_instance_ip == 'localhost' %}localhost{% else %}{{ cloud_instance_ip }}{% endif %}"
     groups: vpn-host
     ansible_connection: "{% if cloud_instance_ip == 'localhost' %}local{% else %}ssh{% endif %}"
-    ansible_ssh_user: "{{ ansible_ssh_user|default('root') }}"
-    ansible_ssh_port: "{{ ansible_ssh_port|default(22) }}"
+    ansible_ssh_user: "{{ ansible_ssh_user | default('root') }}"
+    ansible_ssh_port: "{{ ansible_ssh_port | default(22) }}"
     ansible_python_interpreter: /usr/bin/python3
     algo_provider: "{{ algo_provider }}"
     algo_server_name: "{{ algo_server_name }}"
@@ -21,7 +21,7 @@
     algo_store_pki: "{{ algo_store_pki }}"
     IP_subject_alt_name: "{{ IP_subject_alt_name }}"
     alternative_ingress_ip: "{{ alternative_ingress_ip | default(omit) }}"
-    cloudinit: "{{ cloudinit|default(false) }}"
+    cloudinit: "{{ cloudinit | default(false) }}"
 
 - name: Additional variables for the server
   add_host:
@@ -31,7 +31,7 @@
 
 - name: Wait until SSH becomes ready...
   wait_for:
-    port: "{{ ansible_ssh_port|default(22) }}"
+    port: "{{ ansible_ssh_port | default(22) }}"
     host: "{{ cloud_instance_ip }}"
     search_regex: OpenSSH
     delay: 10

roles/cloud-azure/tasks/prompts.yml

@@ -1,9 +1,9 @@
 ---
 - set_fact:
-    secret: "{{ azure_secret | default(lookup('env','AZURE_SECRET'), true) }}"
-    tenant: "{{ azure_tenant | default(lookup('env','AZURE_TENANT'), true) }}"
-    client_id: "{{ azure_client_id | default(lookup('env','AZURE_CLIENT_ID'), true) }}"
-    subscription_id: "{{ azure_subscription_id | default(lookup('env','AZURE_SUBSCRIPTION_ID'), true) }}"
+    secret: "{{ azure_secret | default(lookup('env', 'AZURE_SECRET'), true) }}"
+    tenant: "{{ azure_tenant | default(lookup('env', 'AZURE_TENANT'), true) }}"
+    client_id: "{{ azure_client_id | default(lookup('env', 'AZURE_CLIENT_ID'), true) }}"
+    subscription_id: "{{ azure_subscription_id | default(lookup('env', 'AZURE_SUBSCRIPTION_ID'), true) }}"
 
 - block:
     - name: Set the default region

roles/cloud-cloudstack/tasks/prompts.yml

@@ -7,7 +7,7 @@
       register: _cs_key
       when:
         - cs_key is undefined
-        - lookup('env','CLOUDSTACK_KEY')|length <= 0
+        - lookup('env', 'CLOUDSTACK_KEY')|length <= 0
 
     - pause:
         prompt: |
@@ -16,7 +16,7 @@
       register: _cs_secret
       when:
         - cs_secret is undefined
-        - lookup('env','CLOUDSTACK_SECRET')|length <= 0
+        - lookup('env', 'CLOUDSTACK_SECRET')|length <= 0
 
     - pause:
         prompt: |
@@ -28,8 +28,8 @@
         - lookup('env', 'CLOUDSTACK_ENDPOINT') | length <= 0
 
     - set_fact:
-        algo_cs_key: "{{ cs_key | default(_cs_key.user_input|default(None)) | default(lookup('env', 'CLOUDSTACK_KEY'), true) }}"
-        algo_cs_token: "{{ cs_secret | default(_cs_secret.user_input|default(None)) | default(lookup('env', 'CLOUDSTACK_SECRET'), true) }}"
+        algo_cs_key: "{{ cs_key | default(_cs_key.user_input | default(None)) | default(lookup('env', 'CLOUDSTACK_KEY'), true) }}"
+        algo_cs_token: "{{ cs_secret | default(_cs_secret.user_input | default(None)) | default(lookup('env', 'CLOUDSTACK_SECRET'), true) }}"
         algo_cs_url: >-
           {{ cs_url | default(_cs_url.user_input|default(None)) |
              default(lookup('env', 'CLOUDSTACK_ENDPOINT'), true) |

roles/cloud-digitalocean/tasks/prompts.yml

@@ -6,11 +6,11 @@
   register: _do_token
   when:
     - do_token is undefined
-    - lookup('env','DO_API_TOKEN')|length <= 0
+    - lookup('env', 'DO_API_TOKEN')|length <= 0
 
 - name: Set the token as a fact
   set_fact:
-    algo_do_token: "{{ do_token | default(_do_token.user_input|default(None)) | default(lookup('env','DO_API_TOKEN'), true) }}"
+    algo_do_token: "{{ do_token | default(_do_token.user_input | default(None)) | default(lookup('env', 'DO_API_TOKEN'), true) }}"
 
 - name: Get regions
   uri:

roles/cloud-ec2/tasks/prompts.yml

@@ -22,7 +22,7 @@
       no_log: true
   when:
     - aws_access_key is undefined
-    - lookup('env','AWS_ACCESS_KEY_ID')|length <= 0
+    - lookup('env', 'AWS_ACCESS_KEY_ID')|length <= 0
 
 # Prompt for credentials if still not available
 - pause:
@@ -33,7 +33,7 @@
   register: _aws_access_key
   when:
     - aws_access_key is undefined
-    - lookup('env','AWS_ACCESS_KEY_ID')|length <= 0
+    - lookup('env', 'AWS_ACCESS_KEY_ID')|length <= 0
     - _file_access_key is undefined or _file_access_key|length <= 0
 
 - pause:
@@ -43,7 +43,7 @@
   register: _aws_secret_key
   when:
     - aws_secret_key is undefined
-    - lookup('env','AWS_SECRET_ACCESS_KEY')|length <= 0
+    - lookup('env', 'AWS_SECRET_ACCESS_KEY')|length <= 0
     - _file_secret_key is undefined or _file_secret_key|length <= 0
 
 # Set final credentials with proper precedence

roles/cloud-gce/tasks/main.yml

@@ -29,7 +29,7 @@
         ports:
           - "500"
           - "4500"
-          - "{{ wireguard_port|string }}"
+          - "{{ wireguard_port | string }}"
       - ip_protocol: tcp
         ports:
           - "{{ ssh_port }}"
@@ -70,7 +70,7 @@
       - network: "{{ gcp_compute_network }}"
         access_configs:
           - name: "{{ algo_server_name }}"
-            nat_ip: "{{ gcp_compute_address|default(None) }}"
+            nat_ip: "{{ gcp_compute_address | default(None) }}"
             type: ONE_TO_ONE_NAT
     tags:
       items:

roles/cloud-gce/tasks/prompts.yml

@@ -6,20 +6,20 @@
   register: _gce_credentials_file
   when:
     - gce_credentials_file is undefined
-    - lookup('env','GCE_CREDENTIALS_FILE_PATH')|length <= 0
+    - lookup('env', 'GCE_CREDENTIALS_FILE_PATH')|length <= 0
 
 - set_fact:
     credentials_file_path: >-
       {{ gce_credentials_file | default(_gce_credentials_file.user_input|default(None)) |
-         default(lookup('env','GCE_CREDENTIALS_FILE_PATH'), true) }}
+         default(lookup('env', 'GCE_CREDENTIALS_FILE_PATH'), true) }}
     ssh_public_key_lookup: "{{ lookup('file', '{{ SSH_keys.public }}') }}"
 
 - set_fact:
     credentials_file_lookup: "{{ lookup('file', '{{ credentials_file_path }}') }}"
 
 - set_fact:
-    service_account_email: "{{ credentials_file_lookup.client_email | default(lookup('env','GCE_EMAIL')) }}"
-    project_id: "{{ credentials_file_lookup.project_id | default(lookup('env','GCE_PROJECT')) }}"
+    service_account_email: "{{ credentials_file_lookup.client_email | default(lookup('env', 'GCE_EMAIL')) }}"
+    project_id: "{{ credentials_file_lookup.project_id | default(lookup('env', 'GCE_PROJECT')) }}"
 
 - block:
     - name: Get regions