Removed RSA and Camellia from list of legacy algorithms

Author: fegge

cpp/src/crypto/MissingZeroization.ql

@@ -13,12 +13,14 @@ import cpp
 import crypto.libraries
 import semmle.code.cpp.dataflow.new.DataFlow
 
+// TODO: Handle `BN_clear_free` as well.
 predicate isCleared(Expr bignum) {
   exists(BN_clear clear |
     DataFlow::localFlow(DataFlow::exprNode(bignum), DataFlow::exprNode(clear.getArgument(0)))
   )
 }
 
+// TODO: Add support for remaining OpenSSL PRNG functions.
 predicate isRandom(Expr bignum) {
   exists(BN_rand rand |
     DataFlow::localFlow(DataFlow::exprNode(bignum), DataFlow::exprNode(rand.getArgument(0)))

cpp/src/crypto/UseOfLegacyAlgorithm.ql

@@ -19,12 +19,12 @@ where
       .matches([
           // Hash functions
           "%md2%", "%md4%", "%md5%", "%ripemd%", "%sha1%", "%whirlpool%", "%streebog%",
+          // KDFs
+          "%pbkdf1%",
           // Symmetric ciphers
-          "%arcfour%", "%blowfish%", "%cast%", "%camellia%", "%des%", "%idea%", "%kasumi%",
-          "%magma%", "%rc2%", "%rc4%", "%tdea%",
-          // Asymmetric ciphers
-          "%rsa%"
-        ])
+          "%arcfour%", "%blowfish%", "%cast%", "%des%", "%idea%", "%kasumi%",
+          "%magma%", "%rc2%", "%rc4%", "%tdea%"
+      ])
 select call.getLocation(),
   "Potential use of legacy cryptographic algorithm " + call.getTarget().getQualifiedName() +
     " detected"