Fix flaky random ZIP creation in TestPolyglotModule#179
Merged
Conversation
Member
|
Thanks for tracking this down! The fix is on the right track, but there's an issue: In def create_random_zip(filename, size=1024):
tmp_filename = "".join(random.choices(...)) # ✅ Affected by seed
with open(tmp_filename, "wb") as f:
f.write(os.urandom(size)) # ❌ NOT affected by seed
To fully fix the flakiness, replace f.write(random.randbytes(size)) # ✅ Respects random.seed()This will make the entire test deterministic. |
fa91aec to
8cc76d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #162 for context. I think the user got (un)lucky and the randomly generated ZIP file looked like a valid Pickle object with 2+ valid opcodes.