Skip to content

Commit 2b0138a

Browse files
authored
[MLIR][mlir-link] Fix alignment get/set to expect comdatOp (#61)
1 parent 7729090 commit 2b0138a

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

mlir/lib/Dialect/LLVMIR/IR/LLVMLinkerInterface.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,9 @@ LLVM::LLVMSymbolLinkerInterface::getAlignment(Operation *op) {
165165
return gv.getAlignment();
166166
if (auto fn = dyn_cast<LLVM::LLVMFuncOp>(op))
167167
return fn.getAlignment();
168-
if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::AliasOp>(op))
169-
return {};
168+
if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::AliasOp,
169+
LLVM::ComdatOp>(op))
170+
return std::nullopt;
170171
llvm_unreachable("unexpected operation");
171172
}
172173

@@ -176,7 +177,8 @@ void LLVM::LLVMSymbolLinkerInterface::setAlignment(
176177
return gv.setAlignment(align);
177178
if (auto fn = dyn_cast<LLVM::LLVMFuncOp>(op))
178179
return fn.setAlignment(align);
179-
if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::AliasOp>(op))
180+
if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::AliasOp,
181+
LLVM::ComdatOp>(op))
180182
return;
181183
llvm_unreachable("unexpected operation");
182184
}

0 commit comments

Comments
 (0)