[MLIR][mlir-link] Remove internalization for now

Author: xlauko

mlir/include/mlir/Linker/Linker.h

@@ -15,15 +15,9 @@
 
 namespace mlir::link {
 
-using InternalizeCallbackFn =
-    std::function<void(ModuleOp, const StringSet<> &)>;
-
 /// These are gathered alphabetically sorted linker options
 class LinkerConfig {
 public:
-  /// Allow operation with no registered dialects.
-  /// This option is for convenience during testing only and discouraged in
-  /// general.
   LinkerConfig &allowUnregisteredDialects(bool allow) {
     allowUnregisteredDialectsFlag = allow;
     return *this;
@@ -32,28 +26,15 @@ class LinkerConfig {
     return allowUnregisteredDialectsFlag;
   }
 
-  LinkerConfig &internalizeLinkedSymbols(bool allow) {
-    internalizeLinkedSymbolsFlag = allow;
-    return *this;
-  }
-  bool shouldInternalizeLinkedSymbols() const {
-    return internalizeLinkedSymbolsFlag;
-  }
-
   LinkerConfig &linkOnlyNeeded(bool allow) {
     linkOnlyNeededFlag = allow;
     return *this;
   }
   bool shouldLinkOnlyNeeded() const { return linkOnlyNeededFlag; }
 
 protected:
-  /// Allow operation with no registered dialects.
-  /// This option is for convenience during testing only and discouraged in
-  /// general.
   bool allowUnregisteredDialectsFlag = false;
 
-  bool internalizeLinkedSymbolsFlag = false;
-
   bool linkOnlyNeededFlag = false;
 };
 
@@ -72,7 +53,6 @@ class Linker {
 
   struct LinkFileConfig {
     unsigned flags = Flags::None;
-    bool internalize = false;
   };
 
   Linker(const LinkerConfig &config, MLIRContext *context)

mlir/lib/Linker/Linker.cpp

@@ -75,8 +75,7 @@ class ModuleLinker {
   }
 
 public:
-  ModuleLinker(IRMover &mover, OwningOpRef<Operation *> src, unsigned flags,
-               InternalizeCallbackFn internalizeCallback = {})
+  ModuleLinker(IRMover &mover, OwningOpRef<Operation *> src, unsigned flags)
       : mover(mover), src(std::move(src)), flags(flags) {}
   LogicalResult run();
 };
@@ -293,7 +292,7 @@ unsigned Linker::getFlags() const {
 }
 
 Linker::LinkFileConfig Linker::linkFileConfig(unsigned fileFlags) const {
-  return {fileFlags, config.shouldInternalizeLinkedSymbols()};
+  return {.flags = fileFlags};
 }
 
 Linker::LinkFileConfig Linker::firstFileConfig(unsigned fileFlags) const {

mlir/lib/Tools/mlir-link/MlirLinkMain.cpp

@@ -82,11 +82,6 @@ struct LinkerCLOptions : public LinkerConfig {
         cl::location(allowUnregisteredDialectsFlag), cl::init(false),
         cl::cat(getCategory()));
 
-    static cl::opt<bool, true> internalizeLinkedSymbols(
-        "internalize", cl::desc("Internalize linked symbols"),
-        cl::location(internalizeLinkedSymbolsFlag), cl::init(false),
-        cl::cat(getCategory()));
-
     static cl::opt<bool, true> linkOnlyNeeded(
         "only-needed", cl::desc("Link only needed symbols"),
         cl::location(linkOnlyNeededFlag), cl::init(false),