[MLIR][mlir-link] Allow linking LLVM aliases

Author: frabert

mlir/lib/Dialect/LLVMIR/IR/LLVMLinkerInterface.cpp

@@ -27,7 +27,7 @@ LLVM::LLVMSymbolLinkerInterface::LLVMSymbolLinkerInterface(Dialect *dialect)
 
 bool LLVM::LLVMSymbolLinkerInterface::canBeLinked(Operation *op) const {
   return isa<LLVM::GlobalOp, LLVM::LLVMFuncOp, LLVM::GlobalCtorsOp,
-             LLVM::GlobalDtorsOp, LLVM::ComdatOp>(op);
+             LLVM::GlobalDtorsOp, LLVM::ComdatOp, LLVM::AliasOp>(op);
 }
 
 //===--------------------------------------------------------------------===//
@@ -39,6 +39,8 @@ Linkage LLVM::LLVMSymbolLinkerInterface::getLinkage(Operation *op) {
     return gv.getLinkage();
   if (auto fn = dyn_cast<LLVM::LLVMFuncOp>(op))
     return fn.getLinkage();
+  if (auto alias = dyn_cast<LLVM::AliasOp>(op))
+    return alias.getLinkage();
   if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::ComdatOp>(op))
     return Linkage::Appending;
   llvm_unreachable("unexpected operation");
@@ -49,6 +51,8 @@ Visibility LLVM::LLVMSymbolLinkerInterface::getVisibility(Operation *op) {
     return gv.getVisibility_();
   if (auto fn = dyn_cast<LLVM::LLVMFuncOp>(op))
     return fn.getVisibility_();
+  if (auto alias = dyn_cast<LLVM::AliasOp>(op))
+    return alias.getVisibility_();
 
   if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::ComdatOp>(op))
     return Visibility::Default;
@@ -61,6 +65,8 @@ void LLVM::LLVMSymbolLinkerInterface::setVisibility(Operation *op,
     return gv.setVisibility_(visibility);
   if (auto fn = dyn_cast<LLVM::LLVMFuncOp>(op))
     return fn.setVisibility_(visibility);
+  if (auto alias = dyn_cast<LLVM::AliasOp>(op))
+    return alias.setVisibility_(visibility);
   // GlobalCotrs and Dtors are defined as operations in mlir
   // but as globals in LLVM IR
   if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::ComdatOp>(op))
@@ -106,7 +112,7 @@ bool LLVM::LLVMSymbolLinkerInterface::isDeclaration(Operation *op) {
     return gv.getInitializerRegion().empty() && !gv.getValue();
   if (auto fn = dyn_cast<LLVM::LLVMFuncOp>(op))
     return fn.getBody().empty();
-  if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::ComdatOp>(op))
+  if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::ComdatOp, LLVM::AliasOp>(op))
     return false;
   llvm_unreachable("unexpected operation");
 }
@@ -129,6 +135,10 @@ UnnamedAddr LLVM::LLVMSymbolLinkerInterface::getUnnamedAddr(Operation *op) {
     auto addr = fn.getUnnamedAddr();
     return addr ? *addr : UnnamedAddr::Global;
   }
+  if (auto alias = dyn_cast<LLVM::AliasOp>(op)) {
+    auto addr = alias.getUnnamedAddr();
+    return addr ? *addr : UnnamedAddr::Global;
+  }
   if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::ComdatOp>(op))
     return UnnamedAddr::Global;
   llvm_unreachable("unexpected operation");
@@ -140,6 +150,8 @@ void LLVM::LLVMSymbolLinkerInterface::setUnnamedAddr(Operation *op,
     return gv.setUnnamedAddr(val);
   if (auto fn = dyn_cast<LLVM::LLVMFuncOp>(op))
     return fn.setUnnamedAddr(val);
+  if (auto alias = dyn_cast<LLVM::AliasOp>(op))
+    return alias.setUnnamedAddr(val);
   // GlobalCotrs and Dtors are defined as operations in mlir
   // but as globals in LLVM IR
   if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::ComdatOp>(op))
@@ -153,14 +165,16 @@ LLVM::LLVMSymbolLinkerInterface::getAlignment(Operation *op) {
     return gv.getAlignment();
   if (auto fn = dyn_cast<LLVM::LLVMFuncOp>(op))
     return fn.getAlignment();
-  if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp>(op))
+  if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::AliasOp>(op))
     return {};
   llvm_unreachable("unexpected operation");
 }
 
 bool LLVM::LLVMSymbolLinkerInterface::isConstant(Operation *op) {
   if (auto gv = dyn_cast<LLVM::GlobalOp>(op))
     return gv.getConstant();
+  if (isa<LLVM::AliasOp>(op))
+    return true;
   if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp>(op))
     return false;
   llvm_unreachable("unexpected operation");
@@ -175,7 +189,7 @@ llvm::StringRef LLVM::LLVMSymbolLinkerInterface::getSection(Operation *op) {
     auto section = fn.getSection();
     return section ? section.value() : llvm::StringRef();
   }
-  if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp>(op))
+  if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp, LLVM::AliasOp>(op))
     return llvm::StringRef();
   llvm_unreachable("unexpected operation");
 }
@@ -184,6 +198,9 @@ uint32_t LLVM::LLVMSymbolLinkerInterface::getAddressSpace(Operation *op) {
   if (auto gv = dyn_cast<LLVM::GlobalOp>(op)) {
     return gv.getAddrSpace();
   }
+  if (auto alias = dyn_cast<LLVM::AliasOp>(op)) {
+    return alias.getAddrSpace();
+  }
   if (isa<LLVM::GlobalCtorsOp, LLVM::GlobalDtorsOp>(op))
     return 0;
   llvm_unreachable("unexpected operation");