-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
I think some tests are getting skipped for reasons that are not great:
test/test_verify.py::TestVerifierPrivate::test_verify_tsr_with_chains[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 38%]
test/test_verify.py::TestVerifierPrivate::test_verify_tsr_with_chains_without_roots[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 41%]
test/test_verify.py::TestVerifierPrivate::test_verify_tsr_with_chains_without_certs[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 44%]
test/test_verify.py::TestVerifierPrivate::test_verify_leaf_certs_mismatch[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 51%]
test/test_verify.py::TestVerifierPrivate::test_verify_leaf_certs_update_cert[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 54%]
test/test_verify.py::TestVerifierPrivate::test_verify_leaf_certs_no_eku[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 57%]
test/test_verify.py::TestVerifierPrivate::test_verify_leaf_certs_non_critical_eku[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 59%]
test/test_verify.py::TestVerifierPrivate::test_verify_leaf_certs_eku_no_values[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 62%]
test/test_verify.py::TestVerifierPrivate::test_verify_leaf_cert_mismatch[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 64%]
test/test_verify.py::TestVerifierPrivate::test_verify_leaf_name_mismatch[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 70%]
test/test_verify.py::TestVerifierPrivate::test_verify_wrong_nonce[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 75%]
test/test_verify.py::TestVerifierPrivate::test_verify_wrong_policy_oid[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 77%]
test/test_verify.py::TestVerifierPrivate::test_verify_wrong_message[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 80%]
test/test_verify.py::TestVerifierPrivate::test_verify_succeeds[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 83%]
test/test_verify.py::TestVerifierPrivate::test_verify_message_with_algo[test_tsa-response-sha256.tsr] SKIPPED (Response file not found: /home/jkukkonen/src/rfc3161-client/test/fixtures/test_tsa/respo...) [ 84%]
test/test_verify.py::TestVerifierPrivate::test_verify_message_with_algo[test_tsa-response-sha384.tsr] SKIPPED (Response file not found: /home/jkukkonen/src/rfc3161-client/test/fixtures/test_tsa/respo...) [ 85%]
test/test_verify.py::TestVerifierPrivate::test_verify_message_with_algo[test_tsa-response-sha512.tsr] SKIPPED (Response file not found: /home/jkukkonen/src/rfc3161-client/test/fixtures/test_tsa/respo...) [ 87%]
test/test_verify.py::TestVerifierPrivate::test_verify_message_with_unsupported_algo[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 93%]
test/test_verify.py::TestVerifierPublic::test_verify_message_succeeds[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 96%]
test/test_verify.py::TestVerifierPublic::test_verify_succeeds[sigstage] SKIPPED (Response file not found for /home/jkukkonen/src/rfc3161-client/test/fixtures/sigstage) [ 98%]
Maybe the ts_response fixture needs to look harder, or maybe we should make a copy of the existing responses at the filename ts_response expects -- if some specific tests fail for a specific tsa, likely those specific failures should be handled instead of this skip.
Metadata
Metadata
Assignees
Labels
No labels