Skip to content

Commit 2584ce0

Browse files
committed
fix: old tests
1 parent bf3f6d6 commit 2584ce0

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

test/unit/validators.test.ts

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -336,22 +336,19 @@ describe("validateSerializedData", () => {
336336
});
337337

338338
describe("invalid partiallyAuditedFile fields", () => {
339-
// Note: validatepartiallyAuditedFile uses OR logic, so it passes if:
340-
// (path && author) OR startLine OR endLine is defined
341-
// This means partial data with coordinates still passes validation
339+
// validatepartiallyAuditedFile uses AND logic: all of
340+
// path, author, startLine, and endLine must be defined.
342341

343-
it("accepts partiallyAuditedFile with coordinates but missing path (OR logic)", () => {
344-
// This passes because startLine is defined (OR logic in validator)
342+
it("rejects partiallyAuditedFile missing path", () => {
345343
const data = createDefaultSerializedData();
346344
data.partiallyAuditedFiles = [{ author: "testuser", startLine: 0, endLine: 10 } as any];
347-
expect(validateSerializedData(data)).to.equal(true);
345+
expect(validateSerializedData(data)).to.equal(false);
348346
});
349347

350-
it("accepts partiallyAuditedFile with coordinates but missing author (OR logic)", () => {
351-
// This passes because startLine is defined (OR logic in validator)
348+
it("rejects partiallyAuditedFile missing author", () => {
352349
const data = createDefaultSerializedData();
353350
data.partiallyAuditedFiles = [{ path: "src/test.ts", startLine: 0, endLine: 10 } as any];
354-
expect(validateSerializedData(data)).to.equal(true);
351+
expect(validateSerializedData(data)).to.equal(false);
355352
});
356353

357354
it("rejects partiallyAuditedFile with all fields undefined", () => {
@@ -360,16 +357,16 @@ describe("validateSerializedData", () => {
360357
expect(validateSerializedData(data)).to.equal(false);
361358
});
362359

363-
it("accepts partiallyAuditedFile with only startLine defined (OR logic)", () => {
360+
it("rejects partiallyAuditedFile with only startLine defined", () => {
364361
const data = createDefaultSerializedData();
365362
data.partiallyAuditedFiles = [{ startLine: 5 } as any];
366-
expect(validateSerializedData(data)).to.equal(true);
363+
expect(validateSerializedData(data)).to.equal(false);
367364
});
368365

369-
it("accepts partiallyAuditedFile with only endLine defined (OR logic)", () => {
366+
it("rejects partiallyAuditedFile with only endLine defined", () => {
370367
const data = createDefaultSerializedData();
371368
data.partiallyAuditedFiles = [{ endLine: 10 } as any];
372-
expect(validateSerializedData(data)).to.equal(true);
369+
expect(validateSerializedData(data)).to.equal(false);
373370
});
374371
});
375372

0 commit comments

Comments
 (0)