feat: add open gh button to the Finding details panel (#103)

* feat: add "Open Remote Issue" button to Finding Details panel title

* fix: readme

Author: fcasal

README.md

@@ -92,7 +92,7 @@ You can fill detailed information about a finding by clicking on it in the _List
 
 ### GitHub/Gitlab Issues
 
-You can create a GitHub/Gitlab issue with the detailed findings information by clicking on the corresponding `Open Remote Issue` button in the _List of Findings_ panel. A browser window in will open prompting you to open the issue with the prefilled information from the _Finding Details_ panel.
+You can create a GitHub/Gitlab issue with the detailed findings information by clicking on the corresponding `Open Remote Issue` button in the _List of Findings_ panel or the same button in the _Finding Details_ view. A browser window will open prompting you to open the issue with the prefilled information from the _Finding Details_ panel.
 
 ![Open Remote Issue](media/readme/gifs/create_gh_issue.gif)
 

package.json

@@ -77,6 +77,11 @@
                 "title": "Open Remote Issue",
                 "icon": "$(github)"
             },
+            {
+                "command": "weAudit.openGithubIssueFromDetails",
+                "title": "Open Remote Issue",
+                "icon": "$(github)"
+            },
             {
                 "command": "weAudit.copyEntryPermalink",
                 "title": "Copy Audit Permalink",
@@ -377,6 +382,11 @@
                     "command": "weAudit.prevGitConfig",
                     "when": "view == gitConfig",
                     "group": "navigation@0"
+                },
+                {
+                    "command": "weAudit.openGithubIssueFromDetails",
+                    "when": "view == findingDetails && weAudit.findingDetailsHasEntry",
+                    "group": "navigation"
                 }
             ],
             "view/item/context": [

src/codeMarker.ts

@@ -4318,6 +4318,14 @@ export class AuditMarker {
             const entry = treeView.selection[0];
             this.showEntryInFindingDetails(entry);
         });
+
+        vscode.commands.registerCommand("weAudit.openGithubIssueFromDetails", () => {
+            const entry = this.getCurrentlySelectedFullEntry();
+            if (entry === undefined) {
+                return;
+            }
+            treeDataProvider.openGithubIssue(entry);
+        });
     }
 
     private showEntryInFindingDetails(entry: TreeEntry): void {
@@ -4339,6 +4347,28 @@ export class AuditMarker {
         vscode.commands.executeCommand("weAudit.setWebviewFindingDetails", entry.details, entry.label);
     }
 
+    /**
+     * Returns the currently selected tree entry as a FullEntry, ignoring grouping and location-only nodes.
+     */
+    private getCurrentlySelectedFullEntry(): FullEntry | undefined {
+        if (treeView.selection.length === 0) {
+            return;
+        }
+
+        let entry = treeView.selection[0];
+        if (isPathOrganizerEntry(entry)) {
+            return;
+        }
+        if (isLocationEntry(entry)) {
+            entry = entry.parentEntry;
+        }
+        if (!isEntry(entry)) {
+            return;
+        }
+
+        return entry;
+    }
+
     /**
      * Selectively reload configurations: if the treeViewMode configuration changed, reload only that.
      * Otherwise, reload all decoration configurations.

src/panels/findingDetailsPanel.ts

@@ -69,6 +69,10 @@ class FindingDetailsProvider implements vscode.WebviewViewProvider {
                 recommendation: entry.recommendation,
                 title: title,
             });
+
+            // Set context to show the "Open Remote Issue" button in the view title
+            // https://code.visualstudio.com/api/references/when-clause-contexts#add-a-custom-when-clause-context
+            vscode.commands.executeCommand("setContext", "weAudit.findingDetailsHasEntry", true);
         }
     }
 
@@ -80,6 +84,10 @@ class FindingDetailsProvider implements vscode.WebviewViewProvider {
             this._view.webview.postMessage({
                 command: "hide-finding-details",
             });
+
+            // Set context to show the "Open Remote Issue" button in the view title
+            // https://code.visualstudio.com/api/references/when-clause-contexts#add-a-custom-when-clause-context
+            vscode.commands.executeCommand("setContext", "weAudit.findingDetailsHasEntry", false);
         }
     }