Fix checkstyle violations from sync: logger naming and system.out.println

Co-authored-by: trask <[email protected]>

Author: Copilot

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/TelemetryClientClassFileTransformer.java

@@ -1722,7 +1722,7 @@ public static void main(String[] args) throws Exception {
     content = content.replace("\r\n", "\n");
     content = content.replaceAll("(?m)^[^\n]*visitLineNumber[^\n]*\n", "");
     content = content.replaceAll("(?m)^[^\n]*visitLocalVariable[^\n]*\n", "");
-    System.out.println(content);
+    System.out.println(content); // CHECKSTYLE:OFF SystemOut
   }
 
   @SuppressWarnings("UnnecessarilyFullyQualified")

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/configuration/SnippetConfiguration.java

@@ -16,22 +16,22 @@
 // preview Configuration
 public class SnippetConfiguration {
   private static final String snippet = readSnippet();
-  private static final Logger LOGGER = LoggerFactory.getLogger(SnippetConfiguration.class);
+  private static final Logger logger = LoggerFactory.getLogger(SnippetConfiguration.class);
 
   // visible for testing
   static String readSnippet() {
     ClassLoader classLoader = SnippetConfiguration.class.getClassLoader();
     String resourceName = "browser-sdk-loader-snippet.txt";
     InputStream inputStream = classLoader.getResourceAsStream(resourceName);
     if (inputStream == null) {
-      LOGGER.error("Resource not found: " + resourceName);
+      logger.error("Resource not found: " + resourceName);
       return "";
     }
     try {
       return toString(inputStream);
     } catch (IOException e) {
       // Handle any IO exceptions that occur
-      LOGGER.error("Failed to read javascript-snippet file", e);
+      logger.error("Failed to read javascript-snippet file", e);
     }
     return "";
   }

buildscripts/checkstyle.xml

@@ -326,7 +326,7 @@
         value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
     </module>
     <module name="JavadocMethod">
-      <property name="accessModifiers" value="public"/>
+      <property name="scope" value="public"/>
       <property name="allowMissingParamTags" value="true"/>
       <property name="allowMissingReturnTag" value="true"/>
       <property name="allowedAnnotations" value="Override, Test"/>

etw/java/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/etw/DllFileUtils.java

@@ -18,7 +18,7 @@
 import org.slf4j.LoggerFactory;
 
 class DllFileUtils {
-  private static final Logger LOGGER = LoggerFactory.getLogger(DllFileUtils.class);
+  private static final Logger logger = LoggerFactory.getLogger(DllFileUtils.class);
 
   private DllFileUtils() {}
 
@@ -52,7 +52,7 @@ public static File buildDllLocalPath(@Nullable String versionDirectory) {
     if (!dllPath.exists() || !dllPath.canRead() || !dllPath.canWrite()) {
       throw new IllegalStateException("Failed to create a read/write folder for the native dll.");
     }
-    LOGGER.trace("{} folder exists", dllPath);
+    logger.trace("{} folder exists", dllPath);
 
     return dllPath;
   }
@@ -87,7 +87,7 @@ public static void extractToLocalFolder(File dllOnDisk, String libraryToLoad) th
         }
       }
     }
-    LOGGER.debug("Successfully extracted '{}' to local folder", libraryToLoad);
+    logger.debug("Successfully extracted '{}' to local folder", libraryToLoad);
   }
 
   private static final List<String> CANDIDATE_USERNAME_ENVIRONMENT_VARIABLES =

etw/java/src/main/jni/com/microsoft/applicationinsights/agent/internal/diagnostics/etw/EtwProvider.java

@@ -14,18 +14,18 @@ public class EtwProvider {
   private static final String LIB_FILENAME_64_BIT =
       "applicationinsights-java-etw-provider-x86-64.dll";
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(EtwProvider.class);
+  private static final Logger logger = LoggerFactory.getLogger(EtwProvider.class);
 
   public EtwProvider(String sdkVersion) {
     String osname = System.getProperty("os.name");
     if (osname != null && osname.startsWith("Windows")) {
       File dllPath = null;
       try {
         dllPath = loadLibrary(sdkVersion);
-        LOGGER.debug("EtwProvider initialized. Lib path={}", dllPath.getAbsolutePath());
+        logger.debug("EtwProvider initialized. Lib path={}", dllPath.getAbsolutePath());
       } catch (Throwable t) {
         try {
-          LOGGER.debug("Error initializing EtwProvider", t);
+          logger.debug("Error initializing EtwProvider", t);
           if (dllPath != null) {
             dllPath.deleteOnExit();
           }

settings.gradle.kts

@@ -5,6 +5,7 @@ pluginManagement {
     id("com.github.jk1.dependency-license-report") version "2.9"
     id("me.champeau.jmh") version "0.7.3"
     id("com.gradle.plugin-publish") version "1.3.1"
+    id("com.github.ben-manes.versions") version "0.51.0"
   }
 }