Skip to content

Commit 028c35f

Browse files
Copilottrask
andcommitted
Update baggage-processor module to follow style guide conventions
Co-authored-by: trask <[email protected]>
1 parent 39a1016 commit 028c35f

File tree

5 files changed

+17
-12
lines changed

5 files changed

+17
-12
lines changed

baggage-processor/build.gradle.kts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,14 @@ description = "OpenTelemetry Baggage Span Processor"
88
otelJava.moduleName.set("io.opentelemetry.contrib.baggage.processor")
99

1010
dependencies {
11+
annotationProcessor("com.google.auto.service:auto-service")
12+
1113
api("io.opentelemetry:opentelemetry-api")
1214
api("io.opentelemetry:opentelemetry-sdk")
15+
compileOnly("com.google.auto.service:auto-service")
1316
implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi")
1417

18+
testImplementation("com.google.auto.service:auto-service")
1519
testImplementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
1620
testImplementation("io.opentelemetry:opentelemetry-sdk-testing")
1721
testImplementation("org.mockito:mockito-inline")

baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageLogRecordProcessor.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,7 @@
1616
* This log record processor copies attributes stored in {@link Baggage} into each newly created log
1717
* record.
1818
*/
19-
public class BaggageLogRecordProcessor implements LogRecordProcessor {
20-
21-
/**
22-
* Creates a new {@link BaggageLogRecordProcessor} that copies all baggage entries into the newly
23-
* created log record.
24-
*/
25-
public static BaggageLogRecordProcessor allowAllBaggageKeys() {
26-
return new BaggageLogRecordProcessor(baggageKey -> true);
27-
}
19+
public final class BaggageLogRecordProcessor implements LogRecordProcessor {
2820

2921
private final Predicate<String> baggageKeyPredicate;
3022

@@ -36,6 +28,14 @@ public BaggageLogRecordProcessor(Predicate<String> baggageKeyPredicate) {
3628
this.baggageKeyPredicate = baggageKeyPredicate;
3729
}
3830

31+
/**
32+
* Creates a new {@link BaggageLogRecordProcessor} that copies all baggage entries into the newly
33+
* created log record.
34+
*/
35+
public static BaggageLogRecordProcessor allowAllBaggageKeys() {
36+
return new BaggageLogRecordProcessor(baggageKey -> true);
37+
}
38+
3939
@Override
4040
public void onEmit(Context context, ReadWriteLogRecord logRecord) {
4141
Baggage.fromContext(context)

baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageProcessorCustomizer.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,16 @@
55

66
package io.opentelemetry.contrib.baggage.processor;
77

8+
import com.google.auto.service.AutoService;
89
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizer;
910
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
1011
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1112
import io.opentelemetry.sdk.logs.SdkLoggerProviderBuilder;
1213
import io.opentelemetry.sdk.trace.SdkTracerProviderBuilder;
1314
import java.util.List;
1415

15-
public class BaggageProcessorCustomizer implements AutoConfigurationCustomizerProvider {
16+
@AutoService(AutoConfigurationCustomizerProvider.class)
17+
public final class BaggageProcessorCustomizer implements AutoConfigurationCustomizerProvider {
1618
@Override
1719
public void customize(AutoConfigurationCustomizer autoConfigurationCustomizer) {
1820
autoConfigurationCustomizer

baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageSpanProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* This span processor copies attributes stored in {@link Baggage} into each newly created {@link
1717
* io.opentelemetry.api.trace.Span}.
1818
*/
19-
public class BaggageSpanProcessor implements SpanProcessor {
19+
public final class BaggageSpanProcessor implements SpanProcessor {
2020
private final Predicate<String> baggageKeyPredicate;
2121

2222
/**

baggage-processor/src/main/resources/META-INF/services/io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)