Apply spotless formatting and fix expected/actual order in assertions

Co-authored-by: trask <[email protected]>

Author: Copilot

jfr-connection/src/test/java/io/opentelemetry/contrib/jfr/connection/FlightRecorderDiagnosticCommandConnectionTest.java

@@ -33,14 +33,14 @@ void assertCommercialFeaturesUnlocked() throws Exception {
 
   @Test
   void assertCommercialFeaturesLockedThrows() throws Exception {
-    assertThrows(
-        JfrConnectionException.class,
-        () -> {
-          ObjectName objectName = mock(ObjectName.class);
-          MBeanServerConnection mBeanServerConnection = mockMbeanServer(objectName, "locked");
-          FlightRecorderDiagnosticCommandConnection.assertCommercialFeaturesUnlocked(
-              mBeanServerConnection, objectName);
-        });
+    assertThatThrownBy(
+            () -> {
+              ObjectName objectName = mock(ObjectName.class);
+              MBeanServerConnection mBeanServerConnection = mockMbeanServer(objectName, "locked");
+              FlightRecorderDiagnosticCommandConnection.assertCommercialFeaturesUnlocked(
+                  mBeanServerConnection, objectName);
+            })
+        .isInstanceOf(JfrConnectionException.class);
   }
 
   @Test
@@ -51,15 +51,14 @@ void closeRecording() throws Exception {
 
   @Test
   void testGetStream() throws Exception {
-    assertThrows(
-        UnsupportedOperationException.class,
-        () -> createconnection().getStream(1L, null, null, 0L));
+    assertThatThrownBy(() -> createconnection().getStream(1L, null, null, 0L))
+        .isInstanceOf(UnsupportedOperationException.class);
   }
 
   @Test
   void testCloneRecording() throws Exception {
-    assertThrows(
-        UnsupportedOperationException.class, () -> createconnection().cloneRecording(1, false));
+    assertThatThrownBy(() -> createconnection().cloneRecording(1, false))
+        .isInstanceOf(UnsupportedOperationException.class);
   }
 
   @Test
@@ -74,7 +73,7 @@ void startRecordingParsesIdCorrectly() throws Exception {
     long id =
         connection.startRecording(
             new RecordingOptions.Builder().build(), RecordingConfiguration.PROFILE_CONFIGURATION);
-    assertThat(99).isEqualTo(id);
+    assertThat(id).isEqualTo(99);
   }
 
   @Test

jfr-connection/src/test/java/io/opentelemetry/contrib/jfr/connection/RecordingOptionsTest.java

@@ -91,8 +91,7 @@ private static Stream<Arguments> testGetMaxAgeNegative() {
   @ParameterizedTest
   @MethodSource
   void testGetMaxAgeNegative(String badValue) {
-    assertThatThrownBy(
-        () -> new RecordingOptions.Builder().maxAge(badValue).build())
+    assertThatThrownBy(() -> new RecordingOptions.Builder().maxAge(badValue).build())
         .isInstanceOf(IllegalArgumentException.class);
   }
 
@@ -135,8 +134,7 @@ private static Stream<Arguments> testGetMaxSizeNegative() {
   @ParameterizedTest
   @MethodSource
   void testGetMaxSizeNegative(String badValue) {
-    assertThatThrownBy(
-        () -> new RecordingOptions.Builder().maxSize(badValue).build())
+    assertThatThrownBy(() -> new RecordingOptions.Builder().maxSize(badValue).build())
         .isInstanceOf(IllegalArgumentException.class);
   }
 
@@ -254,8 +252,7 @@ private static Stream<Arguments> testGetDurationNegative() {
   @ParameterizedTest
   @MethodSource
   void testGetDurationNegative(String badValue) {
-    assertThatThrownBy(
-        () -> new RecordingOptions.Builder().duration(badValue).build())
+    assertThatThrownBy(() -> new RecordingOptions.Builder().duration(badValue).build())
         .isInstanceOf(IllegalArgumentException.class);
   }
 

kafka-exporter/src/test/java/io/opentelemetry/contrib/kafka/KafkaSpanExporterBuilderTest.java

@@ -10,7 +10,6 @@
 import static org.apache.kafka.clients.producer.ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG;
 import static org.apache.kafka.clients.producer.ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import com.google.common.collect.ImmutableMap;
 import io.opentelemetry.sdk.trace.data.SpanData;

kafka-exporter/src/test/java/io/opentelemetry/contrib/kafka/SpanDataDeserializerTest.java

@@ -5,8 +5,6 @@
 
 package io.opentelemetry.contrib.kafka;
 
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThat;
 
 import io.opentelemetry.proto.collector.trace.v1.ExportTraceServiceRequest;

kafka-exporter/src/test/java/io/opentelemetry/contrib/kafka/SpanDataSerializerTest.java

@@ -7,7 +7,6 @@
 
 import static io.opentelemetry.contrib.kafka.TestUtil.makeBasicSpan;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThat;
 
 import com.google.common.collect.ImmutableList;
 import io.opentelemetry.proto.collector.trace.v1.ExportTraceServiceRequest;

processors/src/test/java/io/opentelemetry/contrib/filter/FilteringLogRecordProcessorTest.java

@@ -5,8 +5,6 @@
 
 package io.opentelemetry.contrib.filter;
 
-import static org.assertj.core.api.Assertions.assertThat;
-
 import io.opentelemetry.api.logs.Logger;
 import io.opentelemetry.api.trace.Span;
 import io.opentelemetry.api.trace.SpanContext;

processors/src/test/java/io/opentelemetry/contrib/interceptor/InterceptableLogRecordExporterTest.java

@@ -5,8 +5,6 @@
 
 package io.opentelemetry.contrib.interceptor;
 
-import static org.assertj.core.api.Assertions.assertThat;
-
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.common.AttributesBuilder;

processors/src/test/java/io/opentelemetry/contrib/interceptor/InterceptableMetricExporterTest.java

@@ -5,7 +5,6 @@
 
 package io.opentelemetry.contrib.interceptor;
 
-import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThat;
 
 import io.opentelemetry.api.metrics.Meter;

processors/src/test/java/io/opentelemetry/contrib/interceptor/InterceptableSpanExporterTest.java

@@ -5,8 +5,6 @@
 
 package io.opentelemetry.contrib.interceptor;
 
-import static org.assertj.core.api.Assertions.assertThat;
-
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.common.AttributesBuilder;

resource-providers/src/test/java/io/opentelemetry/contrib/resourceproviders/JettyServiceNameDetectorTest.java

@@ -6,8 +6,6 @@
 package io.opentelemetry.contrib.resourceproviders;
 
 import static io.opentelemetry.contrib.resourceproviders.JettyAppServer.parseJettyBase;
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThat;
 
 import java.io.IOException;
 import java.nio.file.Files;