Skip to content

Commit 1a08020

Browse files
committed
Merge PR #259: [WIP] Update jfr-connection module to follow style guide
2 parents 80b8105 + fb51291 commit 1a08020

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/JfrConnectionException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
* This cause indicates a bug in the io.opentelemetry.contrib.jfr.connection package code.
3838
* </dl>
3939
*/
40-
public class JfrConnectionException extends Exception {
40+
public final class JfrConnectionException extends Exception {
4141

4242
private static final long serialVersionUID = 7394612902107510439L;
4343

jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/PredefinedConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* option of the JVM option 'StartFlightRecording', for example {@code
1818
* -XX:StartFlightRecording:settings=default.jfc}.
1919
*/
20-
public class PredefinedConfiguration implements RecordingConfiguration {
20+
public final class PredefinedConfiguration implements RecordingConfiguration {
2121
private final String configurationName;
2222

2323
@Override

jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/Recording.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
* @see <a
2222
* href="https://docs.oracle.com/en/java/javase/11/docs/api/jdk.jfr/jdk/jfr/Recording.html">jdk.jfr.Recording</a>
2323
*/
24-
public class Recording implements AutoCloseable {
24+
public final class Recording implements AutoCloseable {
2525

2626
/**
2727
* A {@code Recording} may be in one of these states. Note that a {@code Recording} is no longer

jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/RecordingOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
* it does mean that the Builder needs to validate the args and potentially throw
4242
* IllegalArgumentException. String makes the overall code so much simpler.
4343
*/
44-
public class RecordingOptions {
44+
public final class RecordingOptions {
4545

4646
private static final String NO_LIMIT = "0";
4747

0 commit comments

Comments
 (0)