Skip to content

Commit 5d4eaf5

Browse files
committed
Merge PR #384: Update ibm-mq-metrics module to follow style guide
2 parents d5cf543 + bd65945 commit 5d4eaf5

File tree

8 files changed

+11
-10
lines changed

8 files changed

+11
-10
lines changed

ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/WmqContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* authorization.<br>
1818
* It also validates the arguments passed for various scenarios.
1919
*/
20-
public class WmqContext {
20+
public final class WmqContext {
2121
private static final String TRANSPORT_TYPE_CLIENT = "Client";
2222
private static final String TRANSPORT_TYPE_BINDINGS = "Bindings";
2323

ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/WmqMonitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
import org.slf4j.Logger;
4444
import org.slf4j.LoggerFactory;
4545

46-
public class WmqMonitor {
46+
public final class WmqMonitor {
4747

4848
private static final Logger logger = LoggerFactory.getLogger(WmqMonitor.class);
4949

ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/config/ExcludeFilters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import java.util.Set;
1313

1414
/** A jackson databind class used for config. */
15-
public class ExcludeFilters {
15+
public final class ExcludeFilters {
1616

1717
private String type = "UNKNOWN";
1818
private Set<String> values = new HashSet<>();

ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/config/QueueManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
/** This is a jackson databind class used purely for config. */
1212
@JsonIgnoreProperties(ignoreUnknown = true)
13-
public class QueueManager {
13+
public final class QueueManager {
1414

1515
@Nullable private String host;
1616
private int port = -1;

ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/config/ResourceFilters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import java.util.HashSet;
99
import java.util.Set;
1010

11-
public class ResourceFilters {
11+
public final class ResourceFilters {
1212

1313
private Set<String> include = new HashSet<>();
1414
private Set<ExcludeFilters> exclude = new HashSet<>();

ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/metricscollector/MessageBuddy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import com.ibm.mq.headers.pcf.PCFMessage;
1313
import java.time.Instant;
1414

15-
public class MessageBuddy {
15+
public final class MessageBuddy {
1616

1717
private MessageBuddy() {}
1818

ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/util/WmqUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import org.slf4j.Logger;
1717
import org.slf4j.LoggerFactory;
1818

19-
public class WmqUtil {
19+
public final class WmqUtil {
2020

2121
private static final Logger logger = LoggerFactory.getLogger(WmqUtil.class);
2222

ibm-mq-metrics/src/test/java/io/opentelemetry/ibm/mq/metricscollector/MetricAssert.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@
55

66
package io.opentelemetry.ibm.mq.metricscollector;
77

8+
import static org.assertj.core.api.Assertions.assertThat;
9+
810
import io.opentelemetry.sdk.metrics.data.LongPointData;
911
import io.opentelemetry.sdk.metrics.data.MetricData;
10-
import org.assertj.core.api.Assertions;
1112

1213
public class MetricAssert {
1314

@@ -24,12 +25,12 @@ static MetricAssert assertThatMetric(MetricData metric, int pointOffset) {
2425
}
2526

2627
MetricAssert hasName(String name) {
27-
Assertions.assertThat(metric.getName()).isEqualTo(name);
28+
assertThat(metric.getName()).isEqualTo(name);
2829
return this;
2930
}
3031

3132
MetricAssert hasValue(long value) {
32-
Assertions.assertThat(
33+
assertThat(
3334
((LongPointData) metric.getLongGaugeData().getPoints().toArray()[this.pointOffset])
3435
.getValue())
3536
.isEqualTo(value);

0 commit comments

Comments
 (0)