Skip to content

Commit 713859b

Browse files
committed
Merge PR #414: Update span-stacktrace module to follow style guide
2 parents 9adec91 + f5aedb4 commit 713859b

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceAutoConfig.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55

66
package io.opentelemetry.contrib.stacktrace;
77

8+
import static java.util.logging.Level.FINE;
9+
import static java.util.logging.Level.SEVERE;
10+
811
import com.google.auto.service.AutoService;
912
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizer;
1013
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
@@ -14,12 +17,11 @@
1417
import java.lang.reflect.InvocationTargetException;
1518
import java.time.Duration;
1619
import java.util.function.Predicate;
17-
import java.util.logging.Level;
1820
import java.util.logging.Logger;
1921
import javax.annotation.Nullable;
2022

2123
@AutoService(AutoConfigurationCustomizerProvider.class)
22-
public class StackTraceAutoConfig implements AutoConfigurationCustomizerProvider {
24+
public final class StackTraceAutoConfig implements AutoConfigurationCustomizerProvider {
2325

2426
private static final Logger log = Logger.getLogger(StackTraceAutoConfig.class.getName());
2527

@@ -50,7 +52,7 @@ static long getMinDuration(ConfigProperties properties) {
5052
log.fine("Stack traces capture is disabled");
5153
} else {
5254
log.log(
53-
Level.FINE,
55+
FINE,
5456
"Stack traces will be added to spans with a minimum duration of {0} nanos",
5557
minDuration);
5658
}
@@ -70,7 +72,7 @@ static Predicate<ReadableSpan> getFilterPredicate(ConfigProperties properties) {
7072

7173
if (filter == null) {
7274
// if value is set, lack of filtering is likely an error and must be reported
73-
Level disabledLogLevel = filterClass != null ? Level.SEVERE : Level.FINE;
75+
java.util.logging.Level disabledLogLevel = filterClass != null ? SEVERE : FINE;
7476
log.log(disabledLogLevel, "Span stacktrace filtering disabled");
7577
return span -> true;
7678
} else {

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceSpanProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import java.io.StringWriter;
1515
import java.util.function.Predicate;
1616

17-
public class StackTraceSpanProcessor implements ExtendedSpanProcessor {
17+
public final class StackTraceSpanProcessor implements ExtendedSpanProcessor {
1818

1919
private final long minSpanDurationNanos;
2020

0 commit comments

Comments
 (0)