Skip to content

Commit ab61e65

Browse files
committed
Merge PR #396: [WIP] Update kafka-exporter module to follow style guide
2 parents ef2831d + 96a81b4 commit ab61e65

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

kafka-exporter/src/main/java/io/opentelemetry/contrib/kafka/KafkaSpanExporter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
@ThreadSafe
2828
@SuppressWarnings("FutureReturnValueIgnored")
29-
public class KafkaSpanExporter implements SpanExporter {
29+
public final class KafkaSpanExporter implements SpanExporter {
3030
private static final Logger logger = LoggerFactory.getLogger(KafkaSpanExporter.class);
3131
private final String topicName;
3232
private final Producer<String, Collection<SpanData>> producer;

kafka-exporter/src/main/java/io/opentelemetry/contrib/kafka/KafkaSpanExporterBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import org.apache.kafka.clients.producer.Producer;
2121
import org.apache.kafka.common.serialization.Serializer;
2222

23-
public class KafkaSpanExporterBuilder {
23+
public final class KafkaSpanExporterBuilder {
2424
private static final long DEFAULT_TIMEOUT_IN_SECONDS = 5L;
2525
private String topicName;
2626
private Producer<String, Collection<SpanData>> producer;
@@ -67,7 +67,7 @@ public KafkaSpanExporter build() {
6767
return new KafkaSpanExporter(topicName, producer, executorService, timeoutInSeconds);
6868
}
6969

70-
public static class ProducerBuilder {
70+
public static final class ProducerBuilder {
7171
private Map<String, Object> config;
7272
private Serializer<String> keySerializer;
7373
private Serializer<Collection<SpanData>> valueSerializer;

kafka-exporter/src/main/java/io/opentelemetry/contrib/kafka/SpanDataDeserializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import org.apache.kafka.common.errors.SerializationException;
1212
import org.apache.kafka.common.serialization.Deserializer;
1313

14-
public class SpanDataDeserializer implements Deserializer<ExportTraceServiceRequest> {
14+
public final class SpanDataDeserializer implements Deserializer<ExportTraceServiceRequest> {
1515
@SuppressWarnings("NullAway")
1616
@Override
1717
public ExportTraceServiceRequest deserialize(String topic, byte[] data) {

kafka-exporter/src/main/java/io/opentelemetry/contrib/kafka/SpanDataSerializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import org.apache.kafka.common.errors.SerializationException;
2121
import org.apache.kafka.common.serialization.Serializer;
2222

23-
public class SpanDataSerializer implements Serializer<Collection<SpanData>> {
23+
public final class SpanDataSerializer implements Serializer<Collection<SpanData>> {
2424
@Override
2525
public byte[] serialize(String topic, Collection<SpanData> data) {
2626
if (Objects.isNull(data)) {

0 commit comments

Comments
 (0)