Skip to content

Commit ccdeb10

Browse files
committed
Merge PR #263: [WIP] Update jmx-metrics module to follow style guide
2 parents 7ccfab7 + fc78164 commit ccdeb10

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/ConfigurationException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
package io.opentelemetry.contrib.jmxmetrics;
77

8-
public class ConfigurationException extends RuntimeException {
8+
public final class ConfigurationException extends RuntimeException {
99
private static final long serialVersionUID = 0L;
1010

1111
public ConfigurationException(final String message, final Throwable cause) {

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/GroovyRunner.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,22 +29,22 @@
2929
import java.util.logging.Logger;
3030
import org.codehaus.groovy.control.CompilationFailedException;
3131

32-
public class GroovyRunner {
32+
public final class GroovyRunner {
3333
private static final Logger logger = Logger.getLogger(GroovyRunner.class.getName());
3434

3535
private final List<Script> scripts;
3636
private final GroovyMetricEnvironment groovyMetricEnvironment;
3737

3838
GroovyRunner(
39-
final JmxConfig config,
40-
final JmxClient jmxClient,
41-
final GroovyMetricEnvironment groovyMetricEnvironment) {
39+
JmxConfig config,
40+
JmxClient jmxClient,
41+
GroovyMetricEnvironment groovyMetricEnvironment) {
4242
this.groovyMetricEnvironment = groovyMetricEnvironment;
4343

4444
List<String> scriptSources = new ArrayList<>();
4545
try {
4646
if (config.targetSystems.size() != 0) {
47-
for (final String target : config.targetSystems) {
47+
for (String target : config.targetSystems) {
4848
String systemResourcePath = "target-systems/" + target + ".groovy";
4949
scriptSources.add(getTargetSystemResourceAsString(systemResourcePath));
5050
}
@@ -59,7 +59,7 @@ public class GroovyRunner {
5959

6060
this.scripts = new ArrayList<>();
6161
try {
62-
for (final String source : scriptSources) {
62+
for (String source : scriptSources) {
6363
this.scripts.add(new GroovyShell().parse(source));
6464
}
6565
} catch (CompilationFailedException e) {

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/JmxClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import javax.management.remote.JMXConnector;
2323
import javax.management.remote.JMXServiceURL;
2424

25-
public class JmxClient {
25+
public final class JmxClient {
2626
private static final Logger logger = Logger.getLogger(JmxClient.class.getName());
2727

2828
private final JMXServiceURL url;

jmx-metrics/src/main/java/io/opentelemetry/contrib/jmxmetrics/InstrumentDescriptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import io.opentelemetry.sdk.metrics.InstrumentValueType;
1111

1212
@AutoValue
13-
abstract class InstrumentDescriptor {
13+
abstract final class InstrumentDescriptor {
1414

1515
static InstrumentDescriptor create(
1616
String name,

0 commit comments

Comments
 (0)