Skip to content

Commit e3d1086

Browse files
committed
Merge branch 'add-copilot-review-instructions' into copilot-base
2 parents a6a3626 + ae9711b commit e3d1086

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

docs/style-guide.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ Consider statically importing the following commonly used methods and constants:
3939
- **Time unit constants**
4040
- `java.util.concurrent.TimeUnit.*` (SECONDS, etc.)
4141
- **OpenTelemetry semantic convention constants**
42-
- All constants under `io.opentelemetry.semconv.**`, except for `io.opentelemetry.semconv.SchemaUrls.*` constants.
42+
- All constants under `io.opentelemetry.semconv.**`, except for
43+
`io.opentelemetry.semconv.SchemaUrls.*` constants.
4344

4445
### Class organization
4546

@@ -64,7 +65,7 @@ methods.
6465
Follow the principle of minimal necessary visibility. Use the most restrictive access modifier that
6566
still allows the code to function correctly.
6667

67-
### Package conventions
68+
### Internal packages
6869

6970
Classes in `.internal` packages are not considered public API and may change without notice. These
7071
packages contain implementation details that should not be used by external consumers.
@@ -75,7 +76,8 @@ packages contain implementation details that should not be used by external cons
7576

7677
### `final` keyword usage
7778

78-
Public non-internal classes should be declared `final` where possible.
79+
Public non-internal classes should be declared `final` where possible. Internal and non-public
80+
classes should not be declared `final`.
7981

8082
Methods should only be declared `final` if they are in public non-internal non-final classes.
8183

0 commit comments

Comments
 (0)