Update gcp-resources module to follow style guide #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guide Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
[WIP] Update gcp-resources module to follow style guide
Update gcp-resources module to follow style guide
Aug 24, 2025
Copilot finished work on behalf of
trask
August 24, 2025 18:01
trask
reviewed
Aug 24, 2025
| * dependency on incubating artifact which can conflict with another incubating version. | ||
| */ | ||
| class IncubatingAttributes { | ||
| final class IncubatingAttributes { |
There was a problem hiding this comment.
You're absolutely right. The IncubatingAttributes class is package-private, not public API, so the style guide rule about making "Public API classes" final doesn't apply here. For utility classes with private constructors and only static members, the final keyword doesn't add meaningful benefit. I've reverted this change in 845d8a3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the gcp-resources module to comply with the project's style guide by making minimal targeted changes:
Changes Made
Added
finalkeyword to public API classesGCPResourceProviderandGcpResourceDetectorclasses final, following the style guide requirement that "Public API classes should be declaredfinalwhere possible"Replaced manual service files with
@AutoServiceannotations@AutoService(ConditionalResourceProvider.class)toGCPResourceProvider@AutoService(ComponentProvider.class)toGcpResourceDetectorwith appropriate@SuppressWarnings("rawtypes")META-INF/services/files as they are now auto-generated by the AutoService annotation processorbuild.gradle.ktsBenefits
The AutoService annotation processor generates the same service provider files that were previously maintained manually, ensuring no functional changes while improving code maintainability.
Fixes #147.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.