Skip to content

Commit 8269e57

Browse files
authored
fix micrometer bridge (open-telemetry#15011)
1 parent 655fd2a commit 8269e57

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/micrometer/MicrometerBridgeAutoConfiguration.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import io.micrometer.core.instrument.MeterRegistry;
1010
import io.opentelemetry.api.OpenTelemetry;
1111
import io.opentelemetry.instrumentation.micrometer.v1_5.OpenTelemetryMeterRegistry;
12+
import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration;
1213
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.ConditionalOnEnabledInstrumentation;
1314
import org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration;
1415
import org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration;
@@ -24,7 +25,7 @@
2425
* any time.
2526
*/
2627
@ConditionalOnEnabledInstrumentation(module = "micrometer", enabledByDefault = false)
27-
@AutoConfigureAfter(MetricsAutoConfiguration.class)
28+
@AutoConfigureAfter({MetricsAutoConfiguration.class, OpenTelemetryAutoConfiguration.class})
2829
@AutoConfigureBefore(CompositeMeterRegistryAutoConfiguration.class)
2930
@ConditionalOnBean(Clock.class)
3031
@ConditionalOnClass(MeterRegistry.class)

smoke-tests-otel-starter/spring-boot-2/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ description = "smoke-tests-otel-starter-spring-boot-2"
77
dependencies {
88
implementation("org.springframework.boot:spring-boot-starter-web")
99
implementation("org.springframework.boot:spring-boot-starter-data-jdbc")
10+
implementation("org.springframework.boot:spring-boot-starter-actuator")
1011
runtimeOnly("com.h2database:h2")
1112
implementation("org.apache.commons:commons-dbcp2")
1213
implementation("org.springframework.kafka:spring-kafka")

smoke-tests-otel-starter/spring-boot-2/src/test/java/io/opentelemetry/spring/smoketest/OtelSpringStarterSmokeTest.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package io.opentelemetry.spring.smoketest;
77

8+
import org.assertj.core.api.AbstractIterableAssert;
89
import org.springframework.boot.test.context.SpringBootTest;
910

1011
@SpringBootTest(
@@ -20,4 +21,11 @@
2021
"otel.instrumentation.runtime-telemetry.emit-experimental-telemetry=true",
2122
"otel.instrumentation.common.thread_details.enabled=true",
2223
})
23-
class OtelSpringStarterSmokeTest extends AbstractOtelSpringStarterSmokeTest {}
24+
class OtelSpringStarterSmokeTest extends AbstractOtelSpringStarterSmokeTest {
25+
26+
@Override
27+
protected void assertAdditionalMetrics() {
28+
testing.waitAndAssertMetrics(
29+
"io.opentelemetry.micrometer-1.5", "disk.total", AbstractIterableAssert::isNotEmpty);
30+
}
31+
}

smoke-tests-otel-starter/spring-boot-common/src/main/resources/application.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ otel:
88
logback-appender:
99
experimental:
1010
capture-code-attributes: true
11+
micrometer:
12+
enabled: true
1113
http:
1214
client:
1315
emit-experimental-telemetry: true

0 commit comments

Comments
 (0)