fix

Author: trask

instrumentation/jdbc/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jdbc/test/DruidDataSourceTest.java

@@ -0,0 +1,88 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.javaagent.instrumentation.jdbc.test;
+
+import static io.opentelemetry.api.trace.SpanKind.INTERNAL;
+import static io.opentelemetry.instrumentation.api.internal.SemconvStability.emitStableDatabaseSemconv;
+import static io.opentelemetry.instrumentation.testing.junit.db.SemconvStabilityUtil.maybeStable;
+import static io.opentelemetry.instrumentation.testing.junit.db.SemconvStabilityUtil.maybeStableDbSystemName;
+import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
+import static io.opentelemetry.semconv.incubating.CodeIncubatingAttributes.CODE_FUNCTION;
+import static io.opentelemetry.semconv.incubating.CodeIncubatingAttributes.CODE_NAMESPACE;
+import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_CONNECTION_STRING;
+import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_NAME;
+import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_SYSTEM;
+import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_USER;
+
+import com.alibaba.druid.pool.DruidDataSource;
+import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension;
+import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
+import java.sql.Connection;
+import java.sql.SQLException;
+import javax.sql.DataSource;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+@SuppressWarnings("deprecation") // using deprecated semconv
+class DruidDataSourceTest {
+
+  @RegisterExtension
+  static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
+
+  private DataSource dataSource;
+
+  @BeforeEach
+  void setUp() {
+    DruidDataSource druidDataSource = new DruidDataSource();
+    druidDataSource.setUrl("jdbc:h2:mem:test");
+    druidDataSource.setDriverClassName("org.h2.Driver");
+    druidDataSource.setUsername("sa");
+    druidDataSource.setPassword("");
+    druidDataSource.setMaxActive(1);
+    this.dataSource = druidDataSource;
+  }
+
+  @AfterEach
+  void tearDown() {
+    if (dataSource instanceof DruidDataSource) {
+      ((DruidDataSource) dataSource).close();
+    }
+  }
+
+  @Test
+  void testGetConnection() throws SQLException {
+    // In DruidDataSource we instrument both DruidPooledConnection getConnection() and the bridge
+    // method Connection getConnection(). Here we call Connection getConnection() that delegates
+    // to DruidPooledConnection getConnection(), and verify that only one span is created.
+    testing.runWithSpan(
+        "parent",
+        () -> {
+          try (Connection connection = dataSource.getConnection()) {
+            return null;
+          }
+        });
+
+    testing.waitAndAssertTraces(
+        trace ->
+            trace.hasSpansSatisfyingExactly(
+                span -> span.hasName("parent").hasKind(INTERNAL).hasNoParent(),
+                span ->
+                    span.hasName("DruidDataSource.getConnection")
+                        .hasKind(INTERNAL)
+                        .hasParent(trace.getSpan(0))
+                        .hasAttributesSatisfyingExactly(
+                            equalTo(CODE_NAMESPACE, "com.alibaba.druid.pool.DruidDataSource"),
+                            equalTo(CODE_FUNCTION, "getConnection"),
+                            equalTo(
+                                DB_CONNECTION_STRING,
+                                emitStableDatabaseSemconv() ? null : "h2:mem:"),
+                            equalTo(maybeStable(DB_NAME), "test"),
+                            equalTo(maybeStable(DB_SYSTEM), maybeStableDbSystemName("h2")),
+                            equalTo(DB_USER, emitStableDatabaseSemconv() ? null : "sa"))));
+  }
+}