Improve logging in RADIUS server and client

This commit provides the following improvements for the logging:

1. Switch to info from debug in the logging messages for the incoming
requests and outgoing responses. There is no big sense in these
messages anyway if everything is normal but more useful during
debugging process.
2. Add logging to the RADIUS client if hostname can not be
resolved. The log messages are added only to the place where we handle
secondary/failover RADIUS servers to not spam with such messages.
3. Remove additional log message for the outgoing response. We already
have such message from the point 1 which has everything what the
removed message had except the RADIUS server name.

Author: 0xAX

src/eradius_client.erl

@@ -435,8 +435,15 @@ store_upstream_servers(Server) ->
 store_radius_server_from_pool(Addr, Port, Retries) when is_tuple(Addr) and is_integer(Port) and is_integer(Retries) ->
     ets:insert(?MODULE, {{Addr, Port}, Retries, Retries});
 store_radius_server_from_pool(Addr, Port, Retries) when is_list(Addr) and is_integer(Port) and is_integer(Retries) ->
-    IP = get_ip(Addr),
-    ets:insert(?MODULE, {{IP, Port}, Retries, Retries});
+    try
+        IP = get_ip(Addr),
+        ets:insert(?MODULE, {{IP, Port}, Retries, Retries})
+    catch error:badarg ->
+      ?LOG(error, "Can't resolve hostname - ~p", [Addr]),
+      % Throw again badarg as it was before to catch non-resolvable hostname during eradius start-up
+      % and exit early to not lost secondary pools.
+      error(badarg)
+    end;
 store_radius_server_from_pool(Addr, Port, Retries) ->
     ?LOG(error, "bad RADIUS upstream server specified in RADIUS servers pool configuration ~p", [{Addr, Port, Retries}]),
     error(badarg).
@@ -630,6 +637,7 @@ find_suitable_peer([{Host, Port, Secret, Opts} | Pool]) when is_list(Host) ->
 	IP = get_ip(Host),
 	find_suitable_peer([{IP, Port, Secret, Opts} | Pool])
     catch _:_ ->
+        ?LOG(error, "Can't resolve hostname - ~p", [Host]),
 	% can't resolve ip by some reasons, just ignore it
 	find_suitable_peer(Pool)
     end;

src/eradius_server.erl

@@ -220,8 +220,6 @@ do_radius(ServerPid, ServerName, ReqKey, Handler = {HandlerMod, _}, NasProp, {ud
     Nodes = eradius_node_mon:get_module_nodes(HandlerMod),
     case run_handler(Nodes, NasProp, Handler, EncRequest) of
         {reply, EncReply, {ReqCmd, RespCmd}, Request} ->
-            ?LOG(debug, "~s From: ~s INF: Sending response for request ~p",
-                        [printable_peer(ServerIP, Port), printable_peer(FromIP, FromPort), ReqKey]),
             TS2 = erlang:monotonic_time(),
             inc_counter({ReqCmd, RespCmd}, ServerName, NasProp, TS2 - TS1, Request),
             gen_udp:send(Socket, FromIP, FromPort, EncReply),
@@ -301,7 +299,7 @@ handle_request({HandlerMod, HandlerArg}, NasProp = #nas_prop{secret = Secret, na
     case eradius_lib:decode_request(EncRequest, Secret) of
         Request = #radius_request{} ->
             Sender = {ServerIP, Port, Request#radius_request.reqid},
-            ?LOG(info, "~s", [eradius_log:collect_message(Sender, Request)],
+            ?LOG(debug, "~s", [eradius_log:collect_message(Sender, Request)],
                  maps:from_list(eradius_log:collect_meta(Sender, Request))),
             eradius_log:write_request(Sender, Request),
             apply_handler_mod(HandlerMod, HandlerArg, Request, NasProp);
@@ -336,7 +334,7 @@ apply_handler_mod(HandlerMod, HandlerArg, Request, NasProp) ->
             EncReply = eradius_lib:encode_reply(Request#radius_request{cmd = ReplyCmd, attrs = ReplyAttrs,
                                                                        msg_hmac = Request#radius_request.msg_hmac or MsgHMAC or (size(EAPmsg) > 0),
                                                                        eap_msg = EAPmsg}),
-            ?LOG(info, "~s", [eradius_log:collect_message(Sender, Reply)],
+            ?LOG(debug, "~s", [eradius_log:collect_message(Sender, Reply)],
                  maps:from_list(eradius_log:collect_meta(Sender, Reply))),
             eradius_log:write_request(Sender, Reply),
             {reply, EncReply, {Request#radius_request.cmd, ReplyCmd}, Request};