Merge pull request #1151 from AndriiMysko/oss-credit-option-fix-am

OSS credit option on by default

Author: AndriiMysko

lib/travis/api/v3/models/organization_preferences.rb

@@ -4,7 +4,7 @@ module Travis::API::V3
   class Models::OrganizationPreferences < Models::JsonSlice
     child Models::Preference
 
-    attribute :consume_oss_credits, Boolean, default: false
+    attribute :consume_oss_credits, Boolean, default: true
 
     # whether to show insights about the organization's private repositories to
     # only admins, all members of the organization, or everybody (public) (note:

lib/travis/api/v3/models/user_preferences.rb

@@ -6,7 +6,7 @@ class Models::UserPreferences < Models::JsonSlice
 
     attribute :build_emails, Boolean, default: true
 
-    attribute :consume_oss_credits, Boolean, default: false
+    attribute :consume_oss_credits, Boolean, default: true
 
     # whether to show insights about the user's private repositories to
     # everybody or keep them only for the user (note: insights about public

spec/v3/services/preferences/for_organization_spec.rb

@@ -50,7 +50,7 @@
                   "@href" => "/v3/org/#{organization.id}/preference/consume_oss_credits",
                   "@representation" => "standard",
                   "name" => "consume_oss_credits",
-                  "value" => false
+                  "value" => true
                 }, {
                   "@type" => "preference",
                   "@href" => "/v3/org/#{organization.id}/preference/private_insights_visibility",
@@ -66,7 +66,7 @@
         describe 'some preference has been set' do
           before do
             organization.preferences.update(:private_insights_visibility, 'members')
-            organization.preferences.update(:consume_oss_credits, true)
+            organization.preferences.update(:consume_oss_credits, false)
           end
 
           it 'returns the set value merged with the defaults' do
@@ -80,7 +80,7 @@
                   "@href" => "/v3/org/#{organization.id}/preference/consume_oss_credits",
                   "@representation" => "standard",
                   "name" => "consume_oss_credits",
-                  "value" => true
+                  "value" => false
                 }, {
                   "@type" => "preference",
                   "@href" => "/v3/org/#{organization.id}/preference/private_insights_visibility",

spec/v3/services/preferences/for_user_spec.rb

@@ -31,7 +31,7 @@
             "@href" => "/v3/preference/consume_oss_credits",
             "@representation" => "standard",
             "name" => "consume_oss_credits",
-            "value" => false
+            "value" => true
           }, {
             "@type" => "preference",
             "@href" => "/v3/preference/private_insights_visibility",
@@ -47,7 +47,7 @@
   describe 'authenticated, user has prefs' do
     before do
       user.preferences.update(:build_emails, false)
-      user.preferences.update(:consume_oss_credits, true)
+      user.preferences.update(:consume_oss_credits, false)
       user.preferences.update(:private_insights_visibility, 'public')
       get("/v3/preferences", {}, auth_headers)
     end
@@ -71,7 +71,7 @@
             "@href" => "/v3/preference/consume_oss_credits",
             "@representation" => "standard",
             "name" => "consume_oss_credits",
-            "value" => true
+            "value" => false
           }, {
             "@type" => "preference",
             "@href" => "/v3/preference/private_insights_visibility",