Merge pull request #1363 from travis-ci/Release_250319

Release 2025 03 19

Author: DominikAlberski

lib/travis/api/serialize/v2/http.rb

@@ -21,3 +21,4 @@
 require 'travis/api/serialize/v2/http/user'
 require 'travis/api/serialize/v2/http/validation_error'
 require 'travis/api/serialize/v2/http/ssh_key'
+require 'travis/api/serialize/v2/http/account_env_var'

lib/travis/api/serialize/v2/http/account_env_var.rb

@@ -0,0 +1,19 @@
+module Travis
+  module Api
+    module Serialize
+      module V2
+        module Http
+          class AccountEnvVar < Travis::Api::Serialize::ObjectSerializer
+            attributes :id, :owner_id, :owner_type, :name, :value, :public, :created_at, :updated_at
+
+            def serializable_hash(adapter_options)
+              hash = super(adapter_options)
+              hash.delete :value unless object.public?
+              hash
+            end
+          end
+        end
+      end
+    end
+  end
+end

lib/travis/api/v3/models/account_env_var.rb

@@ -0,0 +1,46 @@
+module Travis::API::V3
+  class Models::AccountEnvVar < Model
+    belongs_to :owner, polymorphic: true
+
+    serialize :value, Travis::Model::EncryptedColumn.new
+    define_callbacks :after_change
+    set_callback :after_change, :after, :save_audit
+
+    def save_account_env_var!(account_env_var)
+      account_env_var.save if account_env_var.valid?
+      @changes = {
+        created:
+          "name: #{account_env_var.name}, public: #{account_env_var.public}"
+      }
+      run_callbacks :after_change
+      account_env_var
+    end
+
+    def delete(account_env_var)
+      @changes =  {
+        deleted:
+          "name: #{account_env_var.name}, public: #{account_env_var.public}"
+      }
+      account_env_var.destroy
+      run_callbacks :after_change
+    end
+
+    def changes
+      @changes
+    end
+
+    private
+
+    def save_audit
+      Travis::API::V3::Models::Audit.create!(
+        owner: self.owner,
+        change_source: 'travis-api',
+        source: self,
+        source_changes: {
+          account_env_var: self.changes
+        }
+      )
+      @changes = {}
+    end
+  end
+end

lib/travis/api/v3/models/organization.rb

@@ -5,6 +5,7 @@ class Models::Organization < Model
     has_many :memberships
     has_many :users, through: :memberships
     has_one  :beta_migration_request
+    has_many :account_env_vars, as: :owner
 
     has_preferences Models::OrganizationPreferences
 
@@ -43,8 +44,11 @@ def ensure_preferences
     end
 
     def custom_keys
-      return @custom_keys if defined? @custom_keys
-      @custom_keys = Models::CustomKey.where(owner_type: 'Organization', owner_id: id)
+      @custom_keys ||= Models::CustomKey.where(owner_type: 'Organization', owner_id: id)
+    end
+
+    def account_env_vars
+      @account_env_vars ||= Models::AccountEnvVar.where(owner_type: 'Organization', owner_id: id)
     end
 
     alias members users

lib/travis/api/v3/models/user.rb

@@ -12,6 +12,7 @@ class Models::User < Model
     has_many :user_beta_features
     has_many :beta_features, through: :user_beta_features
     has_many :beta_migration_requests
+    has_many :account_env_vars, as: :owner
 
     has_preferences Models::UserPreferences
 
@@ -113,8 +114,12 @@ def ensure_preferences
     end
 
     def custom_keys
-      return @custom_keys if defined? @custom_keys
-      @custom_keys = Models::CustomKey.where(owner_type: 'User', owner_id: id)
+      @custom_keys ||= Models::CustomKey.where(owner_type: 'User', owner_id: id)
     end
+
+    def account_env_vars
+      @account_env_vars ||= Models::AccountEnvVar.where(owner_type: 'User', owner_id: id)
+    end
+
   end
 end

lib/travis/api/v3/permissions/account_env_var.rb

@@ -0,0 +1,23 @@
+require 'travis/api/v3/permissions/generic'
+
+module Travis::API::V3
+  class Permissions::AccountEnvVar < Permissions::Generic
+    def write?
+      object.owner_type == 'Organization' ?
+        authorizer.for_account(object.owner_id, 'account_settings_create') :
+        true
+    end
+
+    def delete?
+      object.owner_type == 'Organization' ?
+        authorizer.for_account(object.owner_id, 'account_settings_delete') :
+        true
+    end
+
+    private
+
+    def organization_permissions
+      @organization_permissions ||= Permissions::Organization.new(access_control, {id: object.owner_id})
+    end
+  end
+end

lib/travis/api/v3/queries/account_env_var.rb

@@ -0,0 +1,17 @@
+module Travis::API::V3
+  class Queries::AccountEnvVar < Query
+
+    def find(params)
+      Models::AccountEnvVar.where(owner_type: params['owner_type'], owner_id: params['owner_id'])
+    end
+
+    def create(account_env_var)
+      raise UnprocessableEntity, "'#{params['name']}' environment variable already exists." unless Models::AccountEnvVar.where(name: params['name'], owner_id: params['owner_id'], owner_type: params['owner_type']).count.zero?
+      account_env_var.save_account_env_var!(account_env_var)
+    end
+
+    def delete(account_env_var)
+      account_env_var.delete(account_env_var)
+    end
+  end
+end

lib/travis/api/v3/renderer/account_env_var.rb

@@ -0,0 +1,6 @@
+module Travis::API::V3
+  class Renderer::AccountEnvVar < ModelRenderer
+    representation :standard, :id, :owner_id, :owner_type, :name, :value, :public, :created_at, :updated_at
+    representation :minimal, :id, :owner_id, :owner_type, :name, :value, :public
+  end
+end

lib/travis/api/v3/renderer/owner.rb

@@ -6,7 +6,7 @@ class Renderer::Owner < ModelRenderer
 
     representation(:minimal,    :id, :login, :name, :vcs_type, :ro_mode)
     representation(:standard,   :id, :login, :name, :github_id, :vcs_id, :vcs_type, :avatar_url, :education,
-                   :allow_migration, :allowance, :ro_mode, :custom_keys, :trial_allowed)
+                   :allow_migration, :allowance, :ro_mode, :custom_keys, :trial_allowed, :account_env_vars)
     representation(:additional, :repositories, :installation, :trial_allowed)
 
     def initialize(model, **options)

lib/travis/api/v3/routes.rb

@@ -353,6 +353,16 @@ module Routes
       delete   :delete
     end
 
+    hidden_resource :account_env_vars do
+      route '/account_env_vars'
+      post   :create
+    end
+
+    hidden_resource :account_env_var do
+      route '/account_env_var/{id}'
+      delete   :delete
+    end
+
     hidden_resource :storage do
       route  '/storage/{id}'
       get    :find