Merge pull request #1255 from travis-ci/bugfix_cycle_12

Bugfix cycle 12

Author: murtaza-swati

lib/travis/api/v3/router.rb

@@ -16,12 +16,12 @@ def initialize(routes = Routes)
 
     def call(env)
       ::Metriks.meter("api.v3.total_requests").mark
+      metrics = @metrics_processor.create
 
       return service_index(env) if env['PATH_INFO'.freeze] == ?/.freeze
 
       process_txt_extension!(env)
 
-      metrics         = @metrics_processor.create
       access_control  = AccessControl.new(env)
       env_params      = params(env)
       factory, params = routes.factory_for(env['REQUEST_METHOD'.freeze], env['PATH_INFO'.freeze])

spec/v3/router_spec.rb

@@ -0,0 +1,26 @@
+describe Travis::API::V3::Router, set_app: true do
+  describe '#call' do
+    let(:env) do
+      {
+        'PATH_INFO' => '/',
+        'rack.request.query_hash' => {},
+      }
+    end
+
+    context 'when user has no perms' do
+      before { env['HTTP_AUTHORIZATION'] = 'Token 123' }
+
+      it 'returns a 403 error' do
+        expect(subject.call(env).first).to eq(403)
+      end
+    end
+
+    context 'when user has perms' do
+      before { env['rack.request.query_hash']['log.token'] = '123' }
+
+      it 'returns a 200 response' do
+        expect(subject.call(env).first).to eq(200)
+      end
+    end
+  end
+end