Skip to content

Commit a27e486

Browse files
committed
Add Travis-API-Version tracking specs
1 parent dafc1d2 commit a27e486

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

lib/travis/api/app/middleware/user_agent_tracker.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class UserAgentTracker < Middleware
1818
attr_reader :metrik_prefix
1919

2020
before do
21-
@metrik_prefix = if version = request.env['HTTP_TRAVIS_API_VERSION']
21+
@metrik_prefix = if version = request.env['HTTP_TRAVIS_API_VERSION'].to_s.match(/^\d+(\.\d+)*/)
2222
"api.v#{version}"
2323
else
2424
"api.v2"

spec/unit/middleware/user_agent_tracker_spec.rb

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,18 @@ def get(env = {}, path = '/')
9090
expect_meter("api.v2.user_agent.script.ruby.travis.version.1.6.8")
9191
get
9292
end
93+
94+
context 'Travis-API-Version header' do
95+
specify "with Travis-API-Version: 3" do
96+
expect_meter("api.v3.user_agent.script.ruby.travis.version.1.6.8")
97+
get('HTTP_TRAVIS_API_VERSION' => '3')
98+
end
99+
100+
specify "with Travis-API-Version: 1.7f" do
101+
expect_meter("api.v1.7.user_agent.script.ruby.travis.version.1.6.8")
102+
get('HTTP_TRAVIS_API_VERSION' => '1.7')
103+
end
104+
end
93105
end
94106

95107
context 'Travis CLI' do

0 commit comments

Comments
 (0)