Skip avatar URL from custom image renderer if email is empty

This might happen when the Assembla commit was made in a non-standard way

Author: Stanislav Colotinschi

lib/travis/api/v3/renderer/custom_image.rb

@@ -6,15 +6,17 @@ class Renderer::CustomImage < ModelRenderer
 
     def created_by
       return nil unless user = model.created_by
+
       {
         '@type' => 'user',
         '@href' => "/v3/user/#{user.id}",
         '@representation' => 'minimal'.freeze,
         'id' => user.id,
         'login' => user.login,
         'name' => user.name,
-        'avatar_url' => user.avatar_url
-      }
+      }.tap do |data|
+        data['avatar_url'] = user.avatar_url if user.email.present?
+      end
     end
   end
 end

spec/v3/services/custom_images/for_owner_spec.rb

@@ -17,15 +17,28 @@
     let!(:custom_image_log) { FactoryBot.create(:custom_image_log, custom_image: custom_image, sender_id: user.id) }
 
     context 'when user has custom images' do
-      it 'returns custom images' do
-        get("/v3/owner/#{user.login}/custom_images", {}, json_headers.merge('HTTP_AUTHORIZATION' => "token #{user_token}"))
+      subject { get("/v3/owner/#{user.login}/custom_images", {}, json_headers.merge('HTTP_AUTHORIZATION' => "token #{user_token}")) }
 
+      it 'returns custom images' do
+        subject
         expect(last_response).to be_ok
-        expect(JSON.parse(last_response.body)['custom_images'].first).to include(
+        custom_image_response = JSON.parse(last_response.body)['custom_images'].first
+        expect(custom_image_response).to include(
           'id' => custom_image.id,
           'name' => custom_image.name,
           'size_bytes' => custom_image.size_bytes
         )
+        expect(custom_image_response['created_by']['avatar_url']).to be_present
+      end
+
+      context 'when user email is blank' do
+        before { user.update(email: nil) }
+
+        it 'skips avatar_url' do
+          subject
+          expect(last_response).to be_ok
+          expect(JSON.parse(last_response.body)['custom_images'].first['created_by']).not_to have_key('avatar_url')
+        end
       end
     end