Skip to content

Commit d23ae91

Browse files
committed
Remove duplicate parameters from ServiceIndex
In particular, `Queries::Cron` defines two identical sets of parameters with different prefixes. This results in duplicates in the ServiceIndex: $ curl -s -H "Travis-API-Version: 3" -H "Accept: application/json" https://api.travis-ci.com | jq .resources.cron.actions.create[].accepted_params [ "cron.interval", "cron.dont_run_if_recent_build_exists", "cron.interval", "cron.dont_run_if_recent_build_exists" ] [ "cron.interval", "cron.dont_run_if_recent_build_exists", "cron.interval", "cron.dont_run_if_recent_build_exists" ] [ "cron.interval", "cron.dont_run_if_recent_build_exists", "cron.interval", "cron.dont_run_if_recent_build_exists" ] [ "cron.interval", "cron.dont_run_if_recent_build_exists", "cron.interval", "cron.dont_run_if_recent_build_exists" ] We avoid this confusion by removing duplicates.
1 parent c7cc424 commit d23ae91

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/travis/api/v3/service_index.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def render_json
133133
:request_method => request_method,
134134
:uri_template => prefix + template
135135
}
136-
action[:accepted_params] = factory.accepted_params if ['POST'.freeze, 'PATCH'.freeze].include? request_method
136+
action[:accepted_params] = factory.accepted_params.uniq if ['POST'.freeze, 'PATCH'.freeze].include? request_method
137137
list << action
138138
end
139139

0 commit comments

Comments
 (0)