Skip to content

Commit f18b678

Browse files
committed
Vary metrik names based on API version used
1 parent 3e09ea8 commit f18b678

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

lib/travis/api/app/middleware/user_agent_tracker.rb

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,14 @@ class UserAgentTracker < Middleware
1111
"Opera", "Mozilla"
1212
]
1313

14+
attr_reader :metrik_prefix
15+
16+
before do
17+
@metrik_prefix = request.env['HTTP_TRAVIS_API_VERSION'] || 'api.v2'
18+
end
19+
1420
before(agent: /^$/) do
15-
::Metriks.meter("api.v2.user_agent.missing").mark
21+
::Metriks.meter("#{metrik_prefix}.user_agent.missing").mark
1622
halt(400, "error" => "missing User-Agent header") if Travis::Features.feature_active?(:require_user_agent)
1723
end
1824

@@ -54,7 +60,7 @@ def mark_unknown
5460
end
5561

5662
def mark(*keys)
57-
key = "api.v2.user_agent." << keys.map { |k| k.to_s.downcase.gsub(/[^a-z0-9\-\.]+/, '_') }.join('.')
63+
key = "#{metrik_prefix}.user_agent." << keys.map { |k| k.to_s.downcase.gsub(/[^a-z0-9\-\.]+/, '_') }.join('.')
5864
::Metriks.meter(key).mark
5965
end
6066
end

0 commit comments

Comments
 (0)