Skip to content

Commit fd693a3

Browse files
committed
Don't create log in api when from admin-v2
1 parent 0481aea commit fd693a3

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

lib/travis/api/v3/models/user_settings.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,9 @@ def job_log_access_older_than_days_restriction
8383
private
8484

8585
def save_audit
86-
Travis::API::V3::Models::Audit.create!(owner: self.user, change_source: self.change_source, source: self.repo, source_changes: { settings: self.changes })
86+
if self.change_source
87+
Travis::API::V3::Models::Audit.create!(owner: self.user, change_source: self.change_source, source: self.repo, source_changes: { settings: self.changes })
88+
end
8789
end
8890
end
8991
end

lib/travis/api/v3/queries/user_setting.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ def find(repository)
66
repository.user_settings.read(_name)
77
end
88

9-
def update(repository, user)
9+
def update(repository, user, from_admin)
1010
user_settings = repository.user_settings
1111
user_settings.user = user
12-
user_settings.change_source = 'travis-api'
12+
user_settings.change_source = 'travis-api' unless from_admin
1313
user_settings.update(_name, _value)
1414
end
1515

lib/travis/api/v3/services/user_setting/update.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ def run!
99

1010
user_setting = query.find(repository)
1111
access_control.permissions(user_setting).write!
12+
app_id = Travis::Api::App::AccessToken.find_by_token(access_control.token).app_id
1213

13-
user_setting = query.update(repository, access_control.user)
14+
user_setting = query.update(repository, access_control.user, app_id == 2)
1415
result user_setting
1516
end
1617
end

0 commit comments

Comments
 (0)