Travis VCS Proxy integration (#2000)

* Travis VCS Proxy integration

* perforce clone

* p4 - setting password

* Travis vcs proxy svn integration (#2005)

* added missing assembla check

Author: AndriiMysko

lib/travis/build.rb

@@ -16,17 +16,15 @@ def config
     module_function :config
 
     def top
-      @top ||= Pathname.new(
-        `git rev-parse --show-toplevel 2>/dev/null`.strip
-      )
+      ::Travis::Vcs::Git::top
     end
 
     module_function :top
 
     class << self
       def version
         return @version if @version
-        @version ||= `git describe --always --dirty --tags 2>/dev/null`.strip
+        @version ||= ::Travis::Vcs::Git::version
         @version = nil unless $?.success?
         @version ||= ENV.fetch('BUILD_SLUG_COMMIT', nil)
         @version ||= top.join('VERSION').read if top.join('VERSION').exist?

lib/travis/build/addons/artifacts/env.rb

@@ -1,13 +1,14 @@
 require 'core_ext/hash/deep_symbolize_keys'
 require 'active_support/core_ext/hash/slice'
+require 'travis/vcs.rb'
 
 module Travis
   module Build
     class Addons
       class Artifacts < Base
         class Env
           DEFAULT = {
-            paths: '$(git ls-files -o | tr "\n" ":")',
+            paths: ::Travis::Vcs::paths,
             log_format: 'multiline'
           }
 

lib/travis/build/addons/deploy/script.rb

@@ -267,10 +267,10 @@ def build_gem_locally_from(source, branch)
               sh.echo "Building dpl gem locally with source #{source} and branch #{branch}", ansi: :yellow
               cmd("gem uninstall -aIx dpl >& /dev/null",                echo: false, assert: !allow_failure, timing: false)
               sh.cmd("pushd /tmp >& /dev/null",                             echo: false, assert: !allow_failure, timing: true)
-              sh.cmd("git clone https://github.com/#{source} #{source}",    echo: true,  assert: !allow_failure, timing: true)
+              sh.cmd(::Travis::Vcs::Git::clone_cmd('https://github.com',source),    echo: true,  assert: !allow_failure, timing: true)
               sh.cmd("pushd #{source} >& /dev/null",                        echo: false, assert: !allow_failure, timing: true)
-              sh.cmd("git checkout #{branch}",                              echo: true,  assert: !allow_failure, timing: true)
-              sh.cmd("git rev-parse HEAD",                                echo: true,  assert: !allow_failure, timing: true)
+              sh.cmd(::Travis::Vcs::Git::checkout_cmd(branch),                              echo: true,  assert: !allow_failure, timing: true)
+              sh.cmd(::Travis::Vcs::Git::revision_cmd,                                echo: true,  assert: !allow_failure, timing: true)
               cmd("gem build dpl.gemspec",                                  echo: true,  assert: !allow_failure, timing: true)
               sh.raw "for f in dpl-*.gemspec; do"
               sh.raw "  base=${f%*.gemspec}"

lib/travis/build/appliances/agent.rb

@@ -1,7 +1,6 @@
 require 'base64'
 require 'travis/build/appliances/base'
 require 'travis/build/appliances/agent/jwt'
-require 'travis/build/git'
 
 module Travis
   module Build

lib/travis/build/appliances/checkout.rb

@@ -1,12 +1,12 @@
 require 'travis/build/appliances/base'
-require 'travis/build/git'
+require 'travis/vcs'
 
 module Travis
   module Build
     module Appliances
       class Checkout < Base
         def apply
-          Git.new(sh, data).checkout
+          Travis::Vcs.checkout(sh, data)
         end
 
         def apply?

lib/travis/build/appliances/rm_etc_boto_cfg.rb

@@ -1,5 +1,4 @@
 require 'travis/build/appliances/base'
-require 'travis/build/git'
 
 module Travis
   module Build

lib/travis/build/appliances/setup_filter.rb

@@ -1,5 +1,4 @@
 require 'travis/build/appliances/base'
-require 'travis/build/git'
 require 'travis/rollout'
 
 module Travis

lib/travis/build/errors.rb

@@ -89,5 +89,11 @@ def initialize(msg = "Unable to fetch GitHub Apps Token. GitHub may be unavailab
         super
       end
     end
+
+    class UnknownServiceTypeError < StandardError
+      def initialize(_type)
+        super
+      end
+    end
   end
 end

lib/travis/build/script.rb

@@ -8,7 +8,7 @@
 require 'travis/build/addons'
 require 'travis/build/appliances'
 require 'travis/build/errors'
-require 'travis/build/git'
+require 'travis/vcs'
 require 'travis/build/helpers'
 require 'travis/build/stages'
 
@@ -84,13 +84,13 @@ class Script
       private_constant :TRAVIS_FUNCTIONS
 
       class << self
-        def defaults(key)
+        def defaults(key, server_type)
           if key && self::DEFAULTS.key?(key.to_sym)
-            Git::DEFAULTS.merge self::DEFAULTS[key.to_sym]
+            Travis::Vcs.defaults(server_type).merge self::DEFAULTS[key.to_sym]
           elsif self::DEFAULTS[:default]
-            Git::DEFAULTS.merge self::DEFAULTS[:default]
+            Travis::Vcs.defaults(server_type).merge self::DEFAULTS[:default]
           else
-            Git::DEFAULTS.merge self::DEFAULTS
+            Travis::Vcs.defaults(server_type).merge self::DEFAULTS
           end
         end
       end
@@ -111,9 +111,10 @@ def defaults(key)
       def initialize(data)
         @raw_data = data.deep_symbolize_keys
         raw_config = @raw_data[:config]
+        server_type = @raw_data.dig(:repository, :server_type) || 'git'
         lang_sym = raw_config.fetch(:language,"").to_sym
         @data = Data.new({
-          config: self.class.defaults(raw_config[:os]),
+          config: self.class.defaults(raw_config[:os], server_type),
           language_default_p: !raw_config[lang_sym]
         }.deep_merge(self.raw_data))
         @options = {}

lib/travis/vcs.rb

@@ -0,0 +1,72 @@
+require 'travis/vcs/base.rb'
+require 'travis/vcs/git.rb'
+require 'travis/vcs/perforce.rb'
+require 'travis/vcs/svn.rb'
+require 'travis/build/errors.rb'
+
+module Travis
+  module Vcs
+    class <<self
+      def top
+        "Travis::Vcs::#{provider_name.to_s.camelize}".constantize.top
+      rescue NameError
+        raise Travis::Build::UnknownServiceTypeError.new provider_name
+      end
+
+      def version
+        "Travis::Vcs::#{provider_name.to_s.camelize}".constantize.version
+      rescue NameError
+        raise Travis::Build::UnknownServiceTypeError.new provider_name
+      end
+
+      def paths
+        "Travis::Vcs::#{provider_name.to_s.camelize}".constantize.paths
+      rescue NameError
+        raise Travis::Build::UnknownServiceTypeError.new(provider_name)
+      end
+
+      def clone_cmd(endpoint, source)
+        "Travis::Vcs::#{provider_name.to_s.camelize}".constantize.clone_cmd(endpoint, source)
+      rescue NameError
+        raise Travis::Build::UnknownServiceTypeError.new provider_name
+      end
+
+      def checkout_cmd(branch)
+        "Travis::Vcs::#{provider_name.to_s.camelize}".constantize.checkout_cmd(branch)
+      rescue NameError
+        raise Travis::Build::UnknownServiceTypeError.new(provider_name)
+      end
+
+      def revision_cmd
+        "Travis::Vcs::#{provider_name.to_s.camelize}".constantize.revision_cmd
+      rescue NameError
+        raise Travis::Build::UnknownServiceTypeError.new provider_name
+      end
+
+      def checkout(sh,data)
+        vcs(sh,data).checkout
+      end
+
+      def defaults(server_type)
+        @provider_name = server_type
+        "Travis::Vcs::#{provider_name.to_s.camelize}".constantize.defaults
+      rescue NameError
+        raise Travis::Build::UnknownServiceTypeError.new provider_name
+      end
+
+      private
+      def vcs(sh,data)
+        provider = data[:repository][:server_type] if data.key?(:repository)
+        provider = provider_name unless provider
+        @provider_name = provider
+        "Travis::Vcs::#{provider.to_s.camelize}".constantize.new(sh,data)
+      rescue NameError
+        raise Travis::Build::UnknownServiceTypeError.new provider_name
+      end
+
+      def provider_name
+        @provider_name ||= 'git'
+      end
+      end
+  end
+end