Skip to content

Commit 26bb572

Browse files
authored
Merge pull request #42 from travis-ci/joshk-more-metrics
improve the librato metrics a bit
2 parents b9c6856 + e3c0860 commit 26bb572

File tree

1 file changed

+18
-3
lines changed

1 file changed

+18
-3
lines changed

lib/travis/listener/app.rb

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,16 @@ def valid_ips
8888
end
8989

9090
def dispatch_event
91-
return unless handle_event?
91+
Metriks.meter("listener.event.#{event_type}").mark
92+
Metriks.meter("listener.integration.#{integration_type}").mark
93+
94+
if handle_event?
95+
Metriks.meter("listener.handle.accept").mark
96+
else
97+
Metriks.meter("listener.handle.reject").mark
98+
return
99+
end
100+
92101
debug "Event payload for #{uuid}: #{payload.inspect}"
93102

94103
if github_pr_event?
@@ -124,8 +133,6 @@ def gatekeeper_event
124133
repository: slug
125134
)
126135

127-
Metriks.meter("listener.event.webhook_#{event_type}").mark
128-
129136
Travis::Sidekiq::Gatekeeper.push(Travis.config.gator.queue, data)
130137
end
131138

@@ -174,6 +181,14 @@ def event_type
174181
env['HTTP_X_GITHUB_EVENT'] || 'push'
175182
end
176183

184+
def integration_type
185+
if !params[:payload].blank?
186+
"webhook"
187+
else
188+
"github_apps"
189+
end
190+
end
191+
177192
def event_details
178193
if event_type == 'pull_request'
179194
{

0 commit comments

Comments
 (0)