Test for _get_check

Author: Snuffy2

tests/test_pyopnsense.py

@@ -146,6 +146,73 @@ async def test_safe_dict_post_and_list_post(monkeypatch, make_client) -> None:
     assert result_empty_list == []
 
 
+@pytest.mark.asyncio
+async def test_get_check(make_client) -> None:
+    """Test _get_check method returns True for ok responses, False otherwise."""
+    session = MagicMock(spec=aiohttp.ClientSession)
+
+    # Fake response class for testing
+    class FakeResp:
+        def __init__(self, status=500, ok=False):
+            self.status = status
+            self.reason = "Test"
+            self.ok = ok
+            self.request_info = MagicMock()
+            self.history = []
+            self.headers = {}
+
+        async def __aenter__(self):
+            return self
+
+        async def __aexit__(self, exc_type, exc, tb):
+            return False
+
+    # Test successful response (ok=True)
+    session.get = lambda *a, **k: FakeResp(status=200, ok=True)
+    client = make_client(session=session)
+    result = await client._get_check("/api/test")
+    assert result is True
+
+    # Test failed response (ok=False)
+    session.get = lambda *a, **k: FakeResp(status=404, ok=False)
+    client = make_client(session=session)
+    result = await client._get_check("/api/test")
+    assert result is False
+
+    # Test 403 response specifically
+    session.get = lambda *a, **k: FakeResp(status=403, ok=False)
+    client = make_client(session=session)
+    result = await client._get_check("/api/test")
+    assert result is False
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize("initial,should_raise", [(False, False), (True, True)])
+async def test_get_check_handles_client_error(make_client, initial, should_raise) -> None:
+    """Ensure _get_check handles aiohttp.ClientError correctly.
+
+    When client is not in initialization mode, the method should swallow the
+    ClientError and return False. When the client is in initialization mode
+    (used during setup), it should re-raise the exception.
+    """
+    session = MagicMock(spec=aiohttp.ClientSession)
+
+    def _raise(*a, **k):
+        raise aiohttp.ClientError("boom")
+
+    session.get = _raise
+    client = make_client(session=session)
+    # simulate the initialization flag behavior
+    client._initial = initial
+
+    if should_raise:
+        with pytest.raises(aiohttp.ClientError):
+            await client._get_check("/api/test")
+    else:
+        result = await client._get_check("/api/test")
+        assert result is False
+
+
 @pytest.mark.asyncio
 async def test_get_ip_key_sorting(make_client) -> None:
     """Sort IP-like items using get_ip_key ordering."""
@@ -358,6 +425,26 @@ async def test_dhcp_leases_and_keep_latest_and_dnsmasq(make_client) -> None:
         await client.async_close()
 
 
+@pytest.mark.asyncio
+async def test_isc_dhcp_service_not_running(make_client) -> None:
+    """Test ISC DHCP lease methods return empty list when service is not running."""
+    session = MagicMock(spec=aiohttp.ClientSession)
+    client = make_client(session=session)
+    try:
+        # Mock _get_check to return False (service not running)
+        client._get_check = AsyncMock(return_value=False)
+
+        # Test DHCPv4
+        leases_v4 = await client._get_isc_dhcpv4_leases()
+        assert leases_v4 == []
+
+        # Test DHCPv6
+        leases_v6 = await client._get_isc_dhcpv6_leases()
+        assert leases_v6 == []
+    finally:
+        await client.async_close()
+
+
 @pytest.mark.asyncio
 async def test_carp_and_reboot_and_wol(make_client) -> None:
     """Verify CARP interface discovery and system control endpoints (reboot/halt/WOL)."""