cleanup php 8 warnings

Signed-off-by: Travis Glenn Hansen <[email protected]>

Author: travisghansen

CHANGELOG.md

@@ -1,3 +1,9 @@
+# v0.5.5
+
+Released 2021-08-01
+
+- handle more stringent type checks by php 8
+
 # v0.5.4
 
 Released 2021-08-01

src/KubernetesPfSenseController/Plugin/DNSHAProxyIngressProxy.php

@@ -142,16 +142,9 @@ public function doAction()
             $ingressProxyPluginStore = [];
         }
 
-        $managedFrontends = $ingressProxyPluginStore['managed_frontends'];
-        if (empty($managedFrontends)) {
-            $managedFrontends = [];
-        }
-
+        $managedFrontends = $ingressProxyPluginStore['managed_frontends'] ?? [];
         $managedHostsPreSave = [];
-        $managedHosts = $store['managed_hosts'];
-        if (empty($managedHosts)) {
-            $managedHosts = [];
-        }
+        $managedHosts = $store['managed_hosts'] ?? [];
 
         foreach ($managedFrontends as $frontendName => $frontendDetails) {
             $primaryFrontendName = $haProxyConfig->getFrontend($frontendName)['primary_frontend'];

src/KubernetesPfSenseController/Plugin/DNSResourceTrait.php

@@ -56,10 +56,7 @@ public function doAction()
                 $store = [];
             }
 
-            $managedHosts = $store['managed_hosts'];
-            if (empty($managedHosts)) {
-                $managedHosts = [];
-            }
+            $managedHosts = $store['managed_hosts'] ?? [];
 
             // actually remove them from config
             $toDeleteHosts = array_diff(@array_keys($managedHosts), @array_keys($managedHostsPreSave));
@@ -72,7 +69,7 @@ public function doAction()
 
             if ($dnsmasqEnabled) {
                 $dnsmasqConfig = PfSenseConfigBlock::getRootConfigBlock($this->getController()->getRegistryItem('pfSenseClient'), 'dnsmasq');
-                if (!is_array($dnsmasqConfig->data['hosts'])) {
+                if (!isset($dnsmasqConfig->data['hosts']) || !is_array($dnsmasqConfig->data['hosts'])) {
                     $dnsmasqConfig->data['hosts'] = [];
                 }
                 foreach ($hosts as $host) {
@@ -90,7 +87,7 @@ public function doAction()
 
             if ($unboundEnabled) {
                 $unboundConfig = PfSenseConfigBlock::getRootConfigBlock($this->getController()->getRegistryItem('pfSenseClient'), 'unbound');
-                if (!is_array($unboundConfig->data['hosts'])) {
+                if (!isset($unboundConfig->data['hosts']) || !is_array($unboundConfig->data['hosts'])) {
                     $unboundConfig->data['hosts'] = [];
                 }
                 foreach ($hosts as $host) {