php 8 updates

Signed-off-by: Travis Glenn Hansen <[email protected]>

Author: travisghansen

CHANGELOG.md

@@ -1,3 +1,10 @@
+# v0.5.2
+
+Released 2021-08-01
+
+- update deploy assets to use modern `apiVersion`s
+- handle more stringent type checks by php 8
+
 # v0.5.1
 
 Released 2021-07-31

README.md

@@ -224,6 +224,14 @@ can be established.  Each `kpc` instance will only require 1 process (ie: access
 
 # Development
 
+## check store values
+
+```
+kubectl -n kube-system get configmaps kubernetes-pfsense-controller-store -o json | jq -crM '.data."haproxy-declarative"' | jq .
+kubectl -n kube-system get configmaps kubernetes-pfsense-controller-store -o json | jq -crM '.data."metallb"' | jq .
+...
+```
+
 ## HAProxy
 XML config structure (note that `ha_backends` is actually frontends...it's badly named):
 ```yaml

deploy/rbac.yaml

@@ -6,7 +6,7 @@ metadata:
   namespace: kube-system
 ---
 kind: ClusterRole
-apiVersion: rbac.authorization.k8s.io/v1beta1
+apiVersion: rbac.authorization.k8s.io/v1
 metadata:
   name: kubernetes-pfsense-controller
 rules:
@@ -40,7 +40,7 @@ rules:
   - watch
 ---
 kind: ClusterRoleBinding
-apiVersion: rbac.authorization.k8s.io/v1beta1
+apiVersion: rbac.authorization.k8s.io/v1
 metadata:
   name: kubernetes-pfsense-controller
 roleRef:

deploy/secret.yaml

@@ -7,4 +7,5 @@ metadata:
 type: Opaque
 data:
   # base64 encoded password
+  # echo -n "mypassword" | base64
   pfsense-password:

src/KubernetesPfSenseController/Plugin/MetalLB.php

@@ -214,6 +214,9 @@ private function doActionGeneric()
 
             // get store data
             $store = $this->getStore();
+            $store[$pluginConfig['bgp-implementation']] = $store[$pluginConfig['bgp-implementation']] ?? [];
+            $store[$pluginConfig['bgp-implementation']]['managed_neighbors'] = $store[$pluginConfig['bgp-implementation']]['managed_neighbors'] ?? [];
+
             $managedNeighborNamesPreSave = @array_keys($managedNeighborsPreSave);
             $managedNeighborNames = @array_keys($store[$pluginConfig['bgp-implementation']]['managed_neighbors']);
             if (empty($managedNeighborNames)) {