Split shared/types.ts into domain, protocol, and scenario modules

Phase 3 of the maintenance plan. The monolithic types.ts (365 LOC)
is replaced by src/shared/types/ with focused modules:
- domain.ts: game entities, actions, map, combat, movement
- protocol.ts: C2S/S2C wire messages
- scenario.ts: scenario configuration types
- index.ts: barrel re-export preserving all existing import paths

Author: rgilks

docs/BACKLOG.md

@@ -62,12 +62,13 @@ These are acceptable for the current standalone/experimental
 scope. Address lifecycle gaps before wiring into core UI
 state (PlanningState, HUD).
 
-### Phase 3. Shared model boundaries
+### ~~Phase 3. Shared model boundaries~~ *(done)*
 
-- Split `src/shared/types.ts` into separate domain, protocol,
-  and scenario type modules.
-- Reduce the number of unrelated changes that currently collide
-  in a single cross-layer file.
+Split `src/shared/types.ts` into `src/shared/types/` directory:
+`domain.ts` (entities, actions, map, combat, movement),
+`protocol.ts` (C2S/S2C), `scenario.ts` (ScenarioDefinition,
+ScenarioPlayer). Barrel `index.ts` preserves all existing
+import paths.
 
 ### Phase 4. Rules consolidation
 
@@ -90,7 +91,7 @@ state (PlanningState, HUD).
 1. ~~Reliability fixes.~~
 2. ~~`main.ts` coordinator extraction.~~
 3. ~~`ui.ts` view extraction.~~
-4. Shared type/module split.
+4. ~~Shared type/module split.~~
 5. Rules consolidation.
 6. Optional stronger state-model refactors.
 

src/shared/types.ts src/shared/types/domain.tssrc/shared/types.ts renamed to src/shared/types/domain.ts

@@ -1,5 +1,4 @@
-import type { GameEvent } from './events';
-import type { HexCoord, HexVec } from './hex';
+import type { HexCoord, HexVec } from '../hex';
 
 // --- Game state ---
 
@@ -234,7 +233,7 @@ export interface MovementEvent {
   capturedBy?: string;
 }
 
-// --- Network messages ---
+// --- Actions ---
 
 export interface OrbitalBaseEmplacement {
   shipId: string;
@@ -244,6 +243,15 @@ export interface FleetPurchase {
   shipType: string;
 }
 
+export interface TransferOrder {
+  sourceShipId: string;
+  targetShipId: string;
+  transferType: 'fuel' | 'cargo';
+  amount: number;
+}
+
+// --- Scenario rules (embedded in GameState) ---
+
 export interface Reinforcement {
   turn: number;
   playerId: number;
@@ -270,95 +278,13 @@ export interface ScenarioRules {
   fleetConversion?: FleetConversion;
 }
 
-export interface TransferOrder {
-  sourceShipId: string;
-  targetShipId: string;
-  transferType: 'fuel' | 'cargo';
-  amount: number;
-}
-
-export type C2S =
-  | { type: 'fleetReady'; purchases: FleetPurchase[] }
-  | { type: 'astrogation'; orders: AstrogationOrder[] }
-  | { type: 'surrender'; shipIds: string[] }
-  | { type: 'ordnance'; launches: OrdnanceLaunch[] }
-  | {
-      type: 'emplaceBase';
-      emplacements: OrbitalBaseEmplacement[];
-    }
-  | { type: 'skipOrdnance' }
-  | { type: 'beginCombat' }
-  | { type: 'combat'; attacks: CombatAttack[] }
-  | { type: 'skipCombat' }
-  | { type: 'logistics'; transfers: TransferOrder[] }
-  | { type: 'skipLogistics' }
-  | { type: 'rematch' }
-  | { type: 'chat'; text: string }
-  | { type: 'ping'; t: number };
-
-export type S2C =
-  | {
-      type: 'welcome';
-      playerId: number;
-      code: string;
-      playerToken: string;
-    }
-  | { type: 'matchFound' }
-  | {
-      type: 'gameStart';
-      state: GameState;
-      eventLog?: GameEvent[];
-    }
-  | {
-      type: 'movementResult';
-      movements: ShipMovement[];
-      ordnanceMovements: OrdnanceMovement[];
-      events: MovementEvent[];
-      state: GameState;
-    }
-  | {
-      type: 'combatResult';
-      results: CombatResult[];
-      state: GameState;
-    }
-  | { type: 'stateUpdate'; state: GameState }
-  | { type: 'gameOver'; winner: number; reason: string }
-  | { type: 'rematchPending' }
-  | { type: 'opponentDisconnected' }
-  | {
-      type: 'chat';
-      playerId: number;
-      text: string;
-    }
-  | { type: 'error'; message: string }
-  | { type: 'pong'; t: number };
-
-// --- Scenario ---
-
+// ScenarioShip is needed here because Reinforcement
+// references it. The full scenario config types
+// (ScenarioDefinition, ScenarioPlayer) live in scenario.ts.
 export interface ScenarioShip {
   type: string;
   position: HexCoord;
   velocity: HexVec;
   startLanded?: boolean;
   startInOrbit?: boolean;
 }
-
-export interface ScenarioPlayer {
-  ships: ScenarioShip[];
-  targetBody: string;
-  homeBody: string;
-  bases?: HexCoord[];
-  escapeWins: boolean;
-  hiddenIdentity?: boolean;
-}
-
-export interface ScenarioDefinition {
-  name: string;
-  description: string;
-  tags?: string[];
-  players: ScenarioPlayer[];
-  rules?: ScenarioRules;
-  startingPlayer?: 0 | 1;
-  startingCredits?: number | [number, number];
-  availableShipTypes?: string[];
-}

src/shared/types/index.ts

@@ -0,0 +1,3 @@
+export * from './domain';
+export * from './protocol';
+export * from './scenario';

src/shared/types/protocol.ts

@@ -0,0 +1,72 @@
+import type { GameEvent } from '../events';
+import type {
+  AstrogationOrder,
+  CombatAttack,
+  CombatResult,
+  FleetPurchase,
+  GameState,
+  MovementEvent,
+  OrbitalBaseEmplacement,
+  OrdnanceLaunch,
+  OrdnanceMovement,
+  ShipMovement,
+  TransferOrder,
+} from './domain';
+
+// --- Network messages ---
+
+export type C2S =
+  | { type: 'fleetReady'; purchases: FleetPurchase[] }
+  | { type: 'astrogation'; orders: AstrogationOrder[] }
+  | { type: 'surrender'; shipIds: string[] }
+  | { type: 'ordnance'; launches: OrdnanceLaunch[] }
+  | {
+      type: 'emplaceBase';
+      emplacements: OrbitalBaseEmplacement[];
+    }
+  | { type: 'skipOrdnance' }
+  | { type: 'beginCombat' }
+  | { type: 'combat'; attacks: CombatAttack[] }
+  | { type: 'skipCombat' }
+  | { type: 'logistics'; transfers: TransferOrder[] }
+  | { type: 'skipLogistics' }
+  | { type: 'rematch' }
+  | { type: 'chat'; text: string }
+  | { type: 'ping'; t: number };
+
+export type S2C =
+  | {
+      type: 'welcome';
+      playerId: number;
+      code: string;
+      playerToken: string;
+    }
+  | { type: 'matchFound' }
+  | {
+      type: 'gameStart';
+      state: GameState;
+      eventLog?: GameEvent[];
+    }
+  | {
+      type: 'movementResult';
+      movements: ShipMovement[];
+      ordnanceMovements: OrdnanceMovement[];
+      events: MovementEvent[];
+      state: GameState;
+    }
+  | {
+      type: 'combatResult';
+      results: CombatResult[];
+      state: GameState;
+    }
+  | { type: 'stateUpdate'; state: GameState }
+  | { type: 'gameOver'; winner: number; reason: string }
+  | { type: 'rematchPending' }
+  | { type: 'opponentDisconnected' }
+  | {
+      type: 'chat';
+      playerId: number;
+      text: string;
+    }
+  | { type: 'error'; message: string }
+  | { type: 'pong'; t: number };

src/shared/types/scenario.ts

@@ -0,0 +1,24 @@
+import type { HexCoord } from '../hex';
+import type { ScenarioRules, ScenarioShip } from './domain';
+
+// --- Scenario configuration ---
+
+export interface ScenarioPlayer {
+  ships: ScenarioShip[];
+  targetBody: string;
+  homeBody: string;
+  bases?: HexCoord[];
+  escapeWins: boolean;
+  hiddenIdentity?: boolean;
+}
+
+export interface ScenarioDefinition {
+  name: string;
+  description: string;
+  tags?: string[];
+  players: ScenarioPlayer[];
+  rules?: ScenarioRules;
+  startingPlayer?: 0 | 1;
+  startingCredits?: number | [number, number];
+  availableShipTypes?: string[];
+}