Fix review issues and update lockfile

Author: rgilks

README.md

@@ -100,6 +100,7 @@ Additional scripts:
 - **Space**: Pause/resume playback
 - **←/→**: Adjust tempo (BPM shown in hint overlay)
 - **↑/↓**: Adjust master volume
+- **M**: Mute/unmute master output
 - **Enter/Escape**: Toggle fullscreen
 
 **🎯 Voice Interaction:**

index.html

@@ -186,6 +186,7 @@ <h3>Keys</h3>
                   <span class="kbd">←/→</span>: tempo •
                   <span class="kbd">↑/↓</span>: volume
                 </li>
+                <li><span class="kbd">M</span>: mute/unmute master</li>
               </ul>
             </div>
             <div>

package-lock.json

@@ -146,7 +146,10 @@ impl MusicEngine {
 
     /// Set beats-per-minute for the internal scheduler.
     pub fn set_bpm(&mut self, bpm: f32) {
-        self.params.bpm = bpm;
+        if !bpm.is_finite() {
+            return;
+        }
+        self.params.bpm = bpm.clamp(1.0, 400.0);
     }
 
     /// Set the global detune offset in cents.
@@ -210,11 +213,18 @@ impl MusicEngine {
 
     /// Advance the scheduler by `dt`, pushing any newly scheduled `NoteEvent`s into `out_events`.
     pub fn tick(&mut self, dt: Duration, out_events: &mut Vec<NoteEvent>) {
-        let seconds_per_beat = 60.0 / self.params.bpm as f64;
+        let bpm = self.params.bpm as f64;
+        if !bpm.is_finite() || bpm <= 0.0 {
+            return;
+        }
+        let step = (60.0 / bpm) / 2.0;
+        if !step.is_finite() || step <= 0.0 {
+            return;
+        }
         self.beat_accum += dt.as_secs_f64();
-        while self.beat_accum >= seconds_per_beat / 2.0 {
+        while self.beat_accum >= step {
             // eighth notes grid
-            self.beat_accum -= seconds_per_beat / 2.0;
+            self.beat_accum -= step;
             self.schedule_step(out_events);
         }
     }

src/core/music.rs

@@ -3,12 +3,17 @@ use crate::core::{
     AEOLIAN, C_MAJOR_PENTATONIC, DORIAN, IONIAN, LOCRIAN, LYDIAN, MIXOLYDIAN, PHRYGIAN,
     TET19_PENTATONIC, TET24_PENTATONIC, TET31_PENTATONIC,
 };
+use crate::events::keymap::{mode_scale_for_digit, root_midi_for_key};
 use crate::overlay;
 use std::cell::RefCell;
 use std::rc::Rc;
 use wasm_bindgen::JsCast;
 use web_sys as web;
 
+thread_local! {
+    static MASTER_UNMUTED_GAIN: RefCell<Option<f32>> = RefCell::new(None);
+}
+
 /// Get the name of the current scale for display purposes
 fn get_scale_name(scale: &[f32]) -> &'static str {
     match scale {
@@ -45,37 +50,6 @@ fn update_hint_after_change(engine: &Rc<RefCell<MusicEngine>>) {
     }
 }
 
-#[inline]
-pub fn root_midi_for_key(key: &str) -> Option<i32> {
-    match key {
-        "a" | "A" => Some(69), // A4
-        "b" | "B" => Some(71), // B4
-        "c" | "C" => Some(60), // C4 (middle C)
-        "d" | "D" => Some(62), // D4
-        "e" | "E" => Some(64), // E4
-        "f" | "F" => Some(65), // F4
-        "g" | "G" => Some(67), // G4
-        _ => None,
-    }
-}
-
-#[inline]
-pub fn mode_scale_for_digit(key: &str) -> Option<&'static [f32]> {
-    match key {
-        "1" => Some(IONIAN),
-        "2" => Some(DORIAN),
-        "3" => Some(PHRYGIAN),
-        "4" => Some(LYDIAN),
-        "5" => Some(MIXOLYDIAN),
-        "6" => Some(AEOLIAN),
-        "7" => Some(LOCRIAN),
-        "8" => Some(TET19_PENTATONIC),
-        "9" => Some(TET24_PENTATONIC),
-        "0" => Some(TET31_PENTATONIC),
-        _ => None,
-    }
-}
-
 pub fn handle_global_keydown(
     ev: &web::KeyboardEvent,
     engine: &Rc<RefCell<MusicEngine>>,
@@ -141,6 +115,22 @@ pub fn handle_global_keydown(
             drop(eng);
             update_hint_after_change(engine);
         }
+        "m" | "M" => {
+            let current_gain = master_gain.gain().value();
+            if current_gain <= 0.0001 {
+                let restored = MASTER_UNMUTED_GAIN
+                    .with(|state| state.borrow_mut().take())
+                    .unwrap_or(0.25)
+                    .clamp(0.0, 1.0);
+                _ = master_gain.gain().set_value(restored);
+                log::info!("[keys] master muted=false");
+            } else {
+                MASTER_UNMUTED_GAIN.with(|state| *state.borrow_mut() = Some(current_gain));
+                _ = master_gain.gain().set_value(0.0);
+                log::info!("[keys] master muted=true");
+            }
+            ev.prevent_default();
+        }
         "," => {
             let mut eng = engine.borrow_mut();
             if ev.shift_key() {

src/events/keyboard.rs

@@ -0,0 +1,35 @@
+use crate::core::{
+    AEOLIAN, DORIAN, IONIAN, LOCRIAN, LYDIAN, MIXOLYDIAN, PHRYGIAN, TET19_PENTATONIC,
+    TET24_PENTATONIC, TET31_PENTATONIC,
+};
+
+#[inline]
+pub fn root_midi_for_key(key: &str) -> Option<i32> {
+    match key {
+        "a" | "A" => Some(69), // A4
+        "b" | "B" => Some(71), // B4
+        "c" | "C" => Some(60), // C4 (middle C)
+        "d" | "D" => Some(62), // D4
+        "e" | "E" => Some(64), // E4
+        "f" | "F" => Some(65), // F4
+        "g" | "G" => Some(67), // G4
+        _ => None,
+    }
+}
+
+#[inline]
+pub fn mode_scale_for_digit(key: &str) -> Option<&'static [f32]> {
+    match key {
+        "1" => Some(IONIAN),
+        "2" => Some(DORIAN),
+        "3" => Some(PHRYGIAN),
+        "4" => Some(LYDIAN),
+        "5" => Some(MIXOLYDIAN),
+        "6" => Some(AEOLIAN),
+        "7" => Some(LOCRIAN),
+        "8" => Some(TET19_PENTATONIC),
+        "9" => Some(TET24_PENTATONIC),
+        "0" => Some(TET31_PENTATONIC),
+        _ => None,
+    }
+}

src/events/keymap.rs

@@ -1,4 +1,5 @@
 pub mod keyboard;
+pub mod keymap;
 pub mod pointer;
 
 pub use keyboard::{wire_global_keydown, wire_overlay_toggle_h};

src/events/mod.rs

@@ -23,8 +23,13 @@ pub fn ray_sphere(ray_origin: Vec3, ray_dir: Vec3, center: Vec3, radius: f32) ->
     if disc < 0.0 {
         return None;
     }
-    let t = -b - disc.sqrt();
-    (t >= 0.0).then_some(t)
+    let sqrt_disc = disc.sqrt();
+    let t_near = -b - sqrt_disc;
+    if t_near >= 0.0 {
+        return Some(t_near);
+    }
+    let t_far = -b + sqrt_disc;
+    (t_far >= 0.0).then_some(t_far)
 }
 
 #[inline]

src/input.rs

@@ -68,15 +68,14 @@ fn ray_sphere_intersection_inside() {
     let radius = 3.0;
 
     let result = ray_sphere(ray_origin, ray_dir, center, radius);
-    // When ray starts inside sphere, the discriminant calculation might fail
-    // This is a limitation of the current implementation
-    // For now, we'll test that it either succeeds or fails gracefully
-    if let Some(t) = result {
-        assert!(t > 0.0);
-        // Should hit at radius distance from center
-        assert!((t - 3.0).abs() < 0.1);
-    }
-    // If it returns None, that's also acceptable for this edge case
+    assert!(
+        result.is_some(),
+        "ray from inside sphere should still intersect"
+    );
+    let t = result.unwrap();
+    assert!(t > 0.0);
+    // Should hit at radius distance from center
+    assert!((t - 3.0).abs() < 0.1);
 }
 
 #[test]