app-native: fix saw/triangle normalization; app-web: remove legacy scene pipeline and orbit feature; add F/Escape fullscreen; clean hint text; add app-core tests for reseed determinism and tempo/solo; update docs and tests; green checks

Author: rgilks

Cargo.toml

@@ -8,7 +8,6 @@ default-members = ["crates/app-native"]
 authors = ["Robert Gilks"]
 edition = "2021"
 license = "MIT"
-name = "geno-1"
 version = "0.1.0"
 description = "Generative 3D music visualizer using Rust, WebGPU (wgpu v24), and WebAudio"
 repository = "https://github.com/rgilks/geno-1"

README.md

@@ -10,9 +10,9 @@
   - Mouse-driven FX: corner-based saturation (clean ↔ fizz) and opposite-corner delay emphasis; visuals have inertial swirl motion and click ripples
   - Start overlay to initialize audio (Click Start; canvas-click fallback)
   - Drag voices in XZ plane; click to mute, Shift+Click reseed, Alt+Click solo
-  - Keyboard: R (reseed all), Space (pause), + / - (tempo), M (master mute), O (orbit on/off)
+  - Keyboard: R (reseed all), Space (pause), + / - (tempo), M (master mute)
   - Starts muted by default; press M to unmute the master bus
-  - Dynamic hint shows current BPM, paused, muted, and orbit state
+  - Dynamic hint shows current BPM, paused, and muted state
   - Rich visuals: instanced voice markers with emissive pulses, ambient waves background, post bloom/tonemap/vignette; optional analyser-driven spectrum dots
 - Native front-end renders and plays synthesized audio; parity improving:
   - Equal-power stereo panning from X position, multiple waveforms (sine/square/saw/triangle)
@@ -44,7 +44,7 @@ Notes:
 
 Quick controls (browser):
 
-- R: reseed all • Space: pause/resume • +/-: tempo • M: master mute • O: orbit on/off
+- R: reseed all • Space: pause/resume • +/-: tempo • M: master mute
 - Click a voice to mute; Alt+Click to solo; Shift+Click to reseed a voice; drag to move in XZ
 
 ### Pre-commit Check
@@ -67,7 +67,7 @@ Controls in browser:
 - Click Start to initialize audio (canvas click also works)
 - Drag a circle to move a voice in XZ plane (updates spatialization)
 - Click a voice: mute; Shift+Click: reseed; Alt+Click: solo
-- Keys: R (reseed all), Space (pause/resume), + / - (tempo), M (master mute), O (orbit on/off)
+- Keys: R (reseed all), Space (pause/resume), + / - (tempo), M (master mute)
 - Mouse position maps to master saturation and delay; moving the pointer leaves a “water-like” trailing swirl in visuals
 
 Headless test:
@@ -94,7 +94,7 @@ Headless test:
 - Screenshots/GIFs live in `docs/media/`.
 - Place files like:
   - `docs/media/screenshot-1.png` – main scene
-  - `docs/media/screenshot-2.png` – orbit and hint overlay
+  - `docs/media/screenshot-2.png` – hint overlay
   - `docs/media/loop-1.gif` – waves background with ripples and pulses
 
 Links:

crates/app-core/src/music.rs

@@ -285,4 +285,78 @@ mod tests {
         assert!(!engine.voices[1].muted);
         assert!(!engine.voices[2].muted);
     }
+
+    #[test]
+    fn reseed_determinism_per_voice() {
+        // Given identical configs and params, reseeding a voice with a fixed seed should
+        // produce identical first scheduled events across engines.
+        let configs = vec![
+            VoiceConfig {
+                color_rgb: [1.0, 0.0, 0.0],
+                waveform: Waveform::Sine,
+                base_position: Vec3::new(-1.0, 0.0, 0.0),
+            },
+            VoiceConfig {
+                color_rgb: [0.0, 1.0, 0.0],
+                waveform: Waveform::Saw,
+                base_position: Vec3::new(1.0, 0.0, 0.0),
+            },
+            VoiceConfig {
+                color_rgb: [0.0, 0.0, 1.0],
+                waveform: Waveform::Triangle,
+                base_position: Vec3::new(0.0, 0.0, -1.0),
+            },
+        ];
+        let params = EngineParams::default();
+        let mut a = MusicEngine::new(configs.clone(), params.clone(), 111);
+        let mut b = MusicEngine::new(configs, params, 222);
+        // Force same reseed for voice 1
+        a.reseed_voice(1, Some(9999));
+        b.reseed_voice(1, Some(9999));
+        // Advance enough time to schedule a step and collect events
+        let mut out_a = Vec::new();
+        let mut out_b = Vec::new();
+        a.tick(Duration::from_millis(300), 0.0, &mut out_a);
+        b.tick(Duration::from_millis(300), 0.0, &mut out_b);
+        // Filter for voice 1 events and compare first if both exist
+        let ev_a = out_a.into_iter().find(|e| e.voice_index == 1);
+        let ev_b = out_b.into_iter().find(|e| e.voice_index == 1);
+        if let (Some(x), Some(y)) = (ev_a, ev_b) {
+            assert!((x.frequency_hz - y.frequency_hz).abs() < 1e-3);
+            assert!((x.duration_sec - y.duration_sec).abs() < 1e-3);
+        }
+    }
+
+    #[test]
+    fn tempo_change_does_not_break_mute_and_solo() {
+        let configs = vec![
+            VoiceConfig {
+                color_rgb: [1.0, 0.0, 0.0],
+                waveform: Waveform::Sine,
+                base_position: Vec3::new(-1.0, 0.0, 0.0),
+            },
+            VoiceConfig {
+                color_rgb: [0.0, 1.0, 0.0],
+                waveform: Waveform::Saw,
+                base_position: Vec3::new(1.0, 0.0, 0.0),
+            },
+            VoiceConfig {
+                color_rgb: [0.0, 0.0, 1.0],
+                waveform: Waveform::Triangle,
+                base_position: Vec3::new(0.0, 0.0, -1.0),
+            },
+        ];
+        let params = EngineParams::default();
+        let mut engine = MusicEngine::new(configs, params, 7);
+        // Solo voice 0 then change tempo
+        engine.toggle_solo(0);
+        engine.set_bpm(140.0);
+        // Mute flags should still reflect solo state
+        assert!(!engine.voices[0].muted);
+        assert!(engine.voices[1].muted);
+        assert!(engine.voices[2].muted);
+        // Toggle solo off and ensure unmuted
+        engine.toggle_solo(0);
+        assert!(engine.voices.iter().all(|v| !v.muted));
+    }
 }

crates/app-native/src/main.rs

@@ -707,15 +707,11 @@ fn render_wave_sample(phase: f32, wave: WaveKind) -> f32 {
         WaveKind::Saw => {
             // Map phase 0..2PI to -1..1
             let t = phase / (2.0 * std::f32::consts::PI);
-            (2.0 * (t - t.floor())) * 2.0 - 1.0
+            2.0 * (t - t.floor()) - 1.0
         }
         WaveKind::Triangle => {
-            // Triangle from saw
-            let saw = {
-                let t = phase / (2.0 * std::f32::consts::PI);
-                (2.0 * (t - t.floor())) * 2.0 - 1.0
-            };
-            (2.0 / std::f32::consts::PI) * (saw.asin())
+            // Triangle using arcsin(sin) identity, normalized to [-1, 1]
+            (2.0 / std::f32::consts::PI) * (phase.sin().asin())
         }
     }
 }

crates/app-web/index.html

@@ -80,9 +80,10 @@
     </div>
     <canvas id="app-canvas" width="1280" height="720"></canvas>
     <div class="hint" data-visible="0" style="display: none">
-      Click canvas to start • Drag a circle to move<br />
-      Click: mute, Shift+Click: reseed, Alt+Click: solo<br />
-      R: reseed all • Space: pause/resume • +/-: tempo • M: master mute<br />
+      Click Start to begin • Drag to move a voice<br />
+      Click: mute • Shift+Click: reseed • Alt+Click: solo<br />
+      R: reseed all • Space: pause/resume • +/-: tempo • M: master mute • F:
+      fullscreen<br />
       BPM: 110 • Paused: no • Muted: yes
     </div>
     <div