Skip to content

Commit 9c5eb24

Browse files
fix: don't call free() on Windows
This may lead to some memory leaks, but at least it won't crash.
1 parent 7369f7f commit 9c5eb24

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/main/java/io/github/treesitter/jtreesitter/Node.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ public final class Node {
2323
private final Arena arena = Arena.ofAuto();
2424
private boolean wasEdited = false;
2525

26+
// FIXME: figure out why free() crashes on Windows
27+
private static final boolean IS_UNIX = !System.getProperty("os.name").startsWith("Windows");
28+
2629
Node(MemorySegment self, Tree tree) {
2730
this.self = self;
2831
this.tree = tree;
@@ -437,7 +440,7 @@ public TreeCursor walk() {
437440
public String toSexp() {
438441
var string = ts_node_string(self);
439442
var result = string.getString(0);
440-
free(string);
443+
if (IS_UNIX) free(string);
441444
return result;
442445
}
443446

src/main/java/io/github/treesitter/jtreesitter/Tree.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ public final class Tree implements AutoCloseable, Cloneable {
2222
private final Language language;
2323
private @Nullable List<Range> includedRanges;
2424

25+
// FIXME: figure out why free() crashes on Windows
26+
private static final boolean IS_UNIX = !System.getProperty("os.name").startsWith("Windows");
27+
2528
Tree(MemorySegment self, Language language, @Nullable String source, @Nullable Charset charset) {
2629
arena = Arena.ofShared();
2730
this.self = self.reinterpret(arena, TreeSitter::ts_tree_delete);
@@ -92,7 +95,7 @@ public List<Range> getIncludedRanges() {
9295
var range = TSRange.asSlice(ranges, i);
9396
includedRanges.add(Range.from(range));
9497
}
95-
free(ranges);
98+
if (IS_UNIX) free(ranges);
9699
}
97100
}
98101
return Collections.unmodifiableList(includedRanges);
@@ -119,7 +122,7 @@ public List<Range> getChangedRanges(Tree newTree) {
119122
var range = TSRange.asSlice(ranges, i);
120123
changedRanges.add(Range.from(range));
121124
}
122-
free(ranges);
125+
if (IS_UNIX) free(ranges);
123126
return changedRanges;
124127
}
125128
}

0 commit comments

Comments
 (0)