fix: use allocation functions through FFM #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #62 Co-Authored-By: maloewe-ona <[email protected]>
Member
Author
|
Can you check if this also works for you? @maloewe-ona |
ghost
mentioned this pull request
ghost
reviewed
Feb 3, 2025
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Can you check if this also works for you? @maloewe-ona
At least the unit tests pass locally for me on Windows; whereas without the ts_set_allocator call they crash the JVM.
Note that so far I have been using x86_64-w64-mingw32-gcc (inside a container) to build the tree-sitter Windows .dll for testing; not sure if that makes a difference. But since the GitHub workflow (which uses MSVC?) encountered the same JVM crash, I assume it does not make a difference.
If possible could you omit the Co-Authored-By:, referring to me, from the commit message?
Thanks for considering to credit me though!
Co-authored-by: maloewe-ona <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62