Small improvements for records and instanceof (#117)

* Support for record declarations as a top level declaration

* Add support for generics in records

* Add support for pattern matching for instanceof

* Fix parse errors when 'record' is used as an identifier

Author: bmahe

grammar.js

@@ -227,7 +227,8 @@ module.exports = grammar({
     instanceof_expression: $ => prec(PREC.REL, seq(
       field('left', $.expression),
       'instanceof',
-      field('right', $._type)
+      field('right', $._type),
+      field('name', optional(choice($.identifier, $._reserved_identifier)))
     )),
 
     lambda_expression: $ => seq(
@@ -635,6 +636,7 @@ module.exports = grammar({
       $.package_declaration,
       $.import_declaration,
       $.class_declaration,
+      $.record_declaration,
       $.interface_declaration,
       $.annotation_type_declaration,
       $.enum_declaration,
@@ -902,6 +904,7 @@ module.exports = grammar({
       optional($.modifiers),
       'record',
       field('name', $.identifier),
+      optional(field('type_parameters', $.type_parameters)),
       field('parameters', $.formal_parameters),
       field('body', $.class_body)
     ),
@@ -1131,7 +1134,8 @@ module.exports = grammar({
 
     _reserved_identifier: $ => alias(choice(
       'open',
-      'module'
+      'module',
+      'record'
     ), $.identifier),
 
     this: $ => 'this',

script/run-javaparser/target/classes/RunJavaParser.class

@@ -2017,6 +2017,31 @@
               "type": "SYMBOL",
               "name": "_type"
             }
+          },
+          {
+            "type": "FIELD",
+            "name": "name",
+            "content": {
+              "type": "CHOICE",
+              "members": [
+                {
+                  "type": "CHOICE",
+                  "members": [
+                    {
+                      "type": "SYMBOL",
+                      "name": "identifier"
+                    },
+                    {
+                      "type": "SYMBOL",
+                      "name": "_reserved_identifier"
+                    }
+                  ]
+                },
+                {
+                  "type": "BLANK"
+                }
+              ]
+            }
           }
         ]
       }
@@ -4366,6 +4391,10 @@
             "type": "SYMBOL",
             "name": "class_declaration"
           },
+          {
+            "type": "SYMBOL",
+            "name": "record_declaration"
+          },
           {
             "type": "SYMBOL",
             "name": "interface_declaration"
@@ -5724,6 +5753,22 @@
             "name": "identifier"
           }
         },
+        {
+          "type": "CHOICE",
+          "members": [
+            {
+              "type": "FIELD",
+              "name": "type_parameters",
+              "content": {
+                "type": "SYMBOL",
+                "name": "type_parameters"
+              }
+            },
+            {
+              "type": "BLANK"
+            }
+          ]
+        },
         {
           "type": "FIELD",
           "name": "parameters",
@@ -6882,6 +6927,10 @@
           {
             "type": "STRING",
             "value": "module"
+          },
+          {
+            "type": "STRING",
+            "value": "record"
           }
         ]
       },

src/grammar.json

@@ -160,6 +160,10 @@
       {
         "type": "package_declaration",
         "named": true
+      },
+      {
+        "type": "record_declaration",
+        "named": true
       }
     ]
   },
@@ -2150,6 +2154,16 @@
           }
         ]
       },
+      "name": {
+        "multiple": false,
+        "required": false,
+        "types": [
+          {
+            "type": "identifier",
+            "named": true
+          }
+        ]
+      },
       "right": {
         "multiple": false,
         "required": true,
@@ -2896,6 +2910,16 @@
             "named": true
           }
         ]
+      },
+      "type_parameters": {
+        "multiple": false,
+        "required": false,
+        "types": [
+          {
+            "type": "type_parameters",
+            "named": true
+          }
+        ]
       }
     },
     "children": {