Skip to content

Improve outer attribute attachment #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve outer attribute attachment #269

wants to merge 3 commits into from

Conversation

wetneb
Copy link

@wetneb wetneb commented Apr 1, 2025 •
edited
Loading

This is another take on #244, which makes sure that outer attributes are properly attached to the elements they annotate.
It brings the grammar closer to rustc, removing 7 cases of inconsistencies noted in #229.

25,27d1
< coverage/attr/nested.rs
< coverage/coroutine.rs
< coverage/coverage_attr_closure.rs
29,31d2
< coverage/yield.rs
< debuginfo/coroutine-locals.rs
< debuginfo/coroutine-objects.rs
36d6
< debuginfo/issue-57822.rs

Closes #244. Closes #276.

@wetneb wetneb mentioned this pull request Apr 1, 2025
Closed
@wetneb
Copy link
Author

wetneb commented Jun 4, 2025

If anyone else is interested in this, the improvement is available in the tree-sitter-rust-orchard fork.

@wetneb wetneb mentioned this pull request Jul 9, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: cannot parse more than one attribute item for function's parameter bug: Incorrect parsing of attributes
1 participant
@wetneb