Prime the repository for Renovate (#1959)

mattseddon · web-flow · commit 30c95b5349b9 · 2022-07-01T08:03:45.000+10:00
* update dependencies

* fix linting issues

* use version 3.0.0 of code climate action

* add more dependencies
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -38,7 +38,7 @@ jobs:
 
       - run: yarn run lint
 
-      - uses: paambaati/codeclimate-action@v2.7.5
+      - uses: paambaati/codeclimate-action@v3.0.0
         env:
           CC_TEST_REPORTER_ID: ${{secrets.CC_TEST_REPORTER_ID}}
         with:
diff --git a/extension/.eslintrc.js b/extension/.eslintrc.js
@@ -10,6 +10,7 @@ module.exports = {
       files: ['src/test/**/*.test.ts'],
       rules: {
         // These aren't jest tests, but still use `expect`
+        'jest/no-standalone-expect': 'off',
         'jest/valid-expect': 'off',
         'no-unused-expressions': 'off'
       }
diff --git a/extension/package.json b/extension/package.json
@@ -1501,10 +1501,10 @@
   },
   "dependencies": {
     "@hediet/std": "^0.6.0",
-    "@vscode/extension-telemetry": "^0.4.10",
+    "@vscode/extension-telemetry": "^0.6.2",
     "appdirs": "^1.1.0",
     "execa": "^5.1.1",
-    "fs-extra": "^10.0.0",
+    "fs-extra": "^10.1.0",
     "js-yaml": "^4.1.0",
     "lodash.clonedeep": "^4.5.0",
     "lodash.get": "^4.4.2",
@@ -1516,41 +1516,42 @@
     "uuid": "^8.3.2"
   },
   "devDependencies": {
-    "@types/chai": "^4.2.22",
+    "@types/chai": "^4.3.1",
     "@types/chai-as-promised": "^7.1.4",
     "@types/copy-webpack-plugin": "^10.1.0",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",
     "@types/js-yaml": "^4.0.5",
-    "@types/lodash.clonedeep": "^4.5.6",
-    "@types/lodash.get": "^4.4.6",
-    "@types/lodash.isempty": "^4.4.6",
-    "@types/lodash.isequal": "^4.5.5",
-    "@types/lodash.merge": "^4.6.6",
-    "@types/lodash.omit": "^4.5.6",
-    "@types/mocha": "^9.1.0",
+    "@types/lodash.clonedeep": "^4.5.7",
+    "@types/lodash.get": "^4.4.7",
+    "@types/lodash.isempty": "^4.4.7",
+    "@types/lodash.isequal": "^4.5.6",
+    "@types/lodash.merge": "^4.6.7",
+    "@types/lodash.omit": "^4.5.7",
+    "@types/mocha": "^9.1.1",
     "@types/mock-require": "^2.0.1",
     "@types/node": "^16.11.8",
     "@types/react-vega": "^7.0.0",
     "@types/sinon-chai": "^3.2.6",
     "@types/uuid": "^8.3.4",
     "@types/vscode": "^1.64.0",
-    "@vscode/test-electron": "^2.1.4",
+    "@vscode/test-electron": "^2.1.5",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
     "clean-webpack-plugin": "^4.0.0",
     "copy-webpack-plugin": "^10.2.4",
-    "fork-ts-checker-webpack-plugin": "^6.5.0",
-    "jest": "^27.5.1",
+    "fork-ts-checker-webpack-plugin": "^7.2.11",
+    "jest": "^28.1.2",
+    "jest-environment-node": "^28.1.2",
     "lint-staged": "^12.3.7",
-    "mocha": "^9.2.2",
+    "mocha": "^10.0.0",
     "mock-require": "^3.0.3",
     "shx": "^0.3.3",
-    "sinon": "^12.0.1",
+    "sinon": "^14.0.0",
     "sinon-chai": "^3.5.0",
-    "ts-jest": "^27.1.4",
-    "ts-loader": "^9.2.6",
-    "vsce": "^2.6.7",
+    "ts-jest": "^28.0.5",
+    "ts-loader": "^9.3.1",
+    "vsce": "^2.9.2",
     "vscode-uri": "^3.0.2",
     "webpack": "^5.73.0",
     "webpack-cli": "^4.9.2"
diff --git a/extension/src/cli/executor.test.ts b/extension/src/cli/executor.test.ts
@@ -409,7 +409,7 @@ describe('CliExecutor', () => {
 
       expect(mockedCreateProcess).toBeCalledWith({
         args: ['move', target, destination],
-        cwd: cwd,
+        cwd,
         env: mockedEnv,
         executable: 'dvc'
       })
diff --git a/extension/src/experiments/model/filterBy/quickPick.ts b/extension/src/experiments/model/filterBy/quickPick.ts
@@ -77,7 +77,7 @@ const addFilterValue = async (path: string, operator: Operator) => {
   }
 
   return {
-    operator: operator,
+    operator,
     path,
     value
   }
@@ -106,7 +106,7 @@ export const pickFilterToAdd = async (
 
   if ([Operator.IS_TRUE, Operator.IS_FALSE].includes(operator)) {
     return {
-      operator: operator,
+      operator,
       path: picked.path,
       value: undefined
     }
diff --git a/extension/src/repository/model/index.ts b/extension/src/repository/model/index.ts
@@ -141,7 +141,7 @@ export class RepositoryModel
   ): PathStatus[] {
     return fileOrStage
       .map(entry => (entry as StageOrFileStatuses)?.[ChangedType.CHANGED_OUTS])
-      .filter(value => value) as PathStatus[]
+      .filter(Boolean) as PathStatus[]
   }
 
   private collectStatuses(acc: ModifiedAndNotInCache, entry: PathStatus) {
diff --git a/extension/src/telemetry/index.test.ts b/extension/src/telemetry/index.test.ts
@@ -1,4 +1,5 @@
 import { extensions } from 'vscode'
+// eslint-disable-next-line import/default
 import TelemetryReporter from '@vscode/extension-telemetry'
 import { getTelemetryReporter, sendTelemetryEvent } from '.'
 import {
diff --git a/extension/src/telemetry/index.ts b/extension/src/telemetry/index.ts
@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/default
 import TelemetryReporter from '@vscode/extension-telemetry'
 import {
   EXTENSION_ID,
diff --git a/extension/src/test/suite/cli/runner.test.ts b/extension/src/test/suite/cli/runner.test.ts
@@ -105,9 +105,9 @@ suite('CLI Runner Test Suite', () => {
 
       const cliRunner = disposable.track(
         new CliRunner({} as Config, 'echo', {
-          processCompleted: processCompleted,
-          processOutput: processOutput,
-          processStarted: processStarted
+          processCompleted,
+          processOutput,
+          processStarted
         })
       )
 
diff --git a/extension/src/util/stdout.ts b/extension/src/util/stdout.ts
@@ -1,6 +1,4 @@
 export const trim = (stdout: string): string => stdout.trim()
 
 export const trimAndSplit = (stdout: string): string[] =>
-  trim(stdout)
-    .split('\n')
-    .filter(i => i)
+  trim(stdout).split('\n').filter(Boolean)
diff --git a/package.json b/package.json
@@ -32,36 +32,37 @@
     "svgr": "yarn workspace dvc-vscode-webview svgr"
   },
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.17.0",
-    "@typescript-eslint/parser": "^5.17.0",
+    "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "@typescript-eslint/parser": "^5.30.0",
     "@vscode/codicons": "^0.0.29",
-    "eslint": "^8.17.0",
+    "eslint": "^8.18.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-config-prettier-standard": "^4.0.1",
-    "eslint-config-standard": "^16.0.3",
+    "eslint-config-standard": "^17.0.0",
     "eslint-plugin-check-file": "^1.1.0",
     "eslint-plugin-etc": "^2.0.2",
-    "eslint-plugin-import": "^2.25.4",
-    "eslint-plugin-jest": "^26.1.3",
-    "eslint-plugin-jsx-a11y": "^6.5.1",
+    "eslint-plugin-import": "^2.26.0",
+    "eslint-plugin-jest": "^26.5.3",
+    "eslint-plugin-jsx-a11y": "^6.6.0",
+    "eslint-plugin-n": "^15.2.3",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-prettier": "^4.2.0",
     "eslint-plugin-promise": "^6.0.0",
     "eslint-plugin-react": "^7.29.4",
     "eslint-plugin-react-hooks": "^4.4.0",
     "eslint-plugin-sonarjs": "^0.13.0",
     "eslint-plugin-sort-keys-fix": "^1.1.2",
     "eslint-plugin-testing-library": "^5.1.0",
-    "eslint-plugin-unicorn": "^41.0.0",
-    "husky": "^7.0.4",
-    "jest": "^27.5.1",
-    "lint-staged": "^12.3.7",
+    "eslint-plugin-unicorn": "^42.0.0",
+    "husky": "^8.0.1",
+    "jest": "^28.1.2",
+    "lint-staged": "^13.0.3",
     "npm-run-all": "^4.1.5",
     "nyc": "^15.1.0",
-    "prettier": "^2.6.1",
+    "prettier": "^2.7.1",
     "prettier-config-standard": "^5.0.0",
-    "ts-node": "^10.7.0",
-    "turbo": "^1.2.1",
+    "ts-node": "^10.8.1",
+    "turbo": "^1.3.1",
     "typescript": "^4.6.3"
   },
   "resolutions": {
diff --git a/webview/package.json b/webview/package.json
@@ -60,23 +60,24 @@
     "@welldone-software/why-did-you-render": "^7.0.1",
     "chromatic": "^6.5.3",
     "clean-webpack-plugin": "^4.0.0",
-    "css-loader": "^6.6.0",
+    "css-loader": "^6.7.1",
     "file-loader": "^6.2.0",
-    "fork-ts-checker-webpack-plugin": "^6.5.0",
+    "fork-ts-checker-webpack-plugin": "^7.2.11",
     "identity-obj-proxy": "^3.0.0",
-    "jest": "^27.5.1",
-    "jest-canvas-mock": "^2.3.1",
+    "jest": "^28.1.2",
+    "jest-canvas-mock": "^2.4.0",
+    "jest-environment-jsdom": "^28.1.2",
     "lint-staged": "^12.3.7",
     "raw-loader": "^4.0.2",
-    "sass": "^1.43.4",
-    "sass-loader": "^12.3.0",
+    "sass": "^1.53.0",
+    "sass-loader": "^13.0.2",
     "storybook-addon-designs": "^6.2.1",
     "style-loader": "^3.3.1",
-    "ts-jest": "^27.1.4",
-    "ts-loader": "^9.2.6",
+    "ts-jest": "^28.0.5",
+    "ts-loader": "^9.3.1",
     "webpack": "^5.73.0",
-    "webpack-cli": "^4.9.2",
-    "webpack-dev-server": "^4.9.2"
+    "webpack-cli": "^4.10.0",
+    "webpack-dev-server": "^4.9.3"
   },
   "svgr": {
     "typescript": true,
diff --git a/webview/src/plots/components/checkpointPlots/CheckpointPlotsWrapper.tsx b/webview/src/plots/components/checkpointPlots/CheckpointPlotsWrapper.tsx
@@ -39,7 +39,7 @@ export const CheckpointPlotsWrapper: React.FC = () => {
       sectionKey={Section.CHECKPOINT_PLOTS}
       menu={{
         plots: metrics,
-        selectedPlots: selectedPlots,
+        selectedPlots,
         setSelectedPlots: setSelectedMetrics
       }}
       currentSize={size}
diff --git a/webview/src/plots/components/webviewSlice.ts b/webview/src/plots/components/webviewSlice.ts
@@ -30,11 +30,12 @@ export const webviewSlice = createSlice({
   initialState: webviewInitialState,
   name: 'webview',
   reducers: {
-    initialize: state => {
+    initialize: (state: { hasData: boolean }) => {
       state.hasData = true
     },
     setZoomedInPlot: (
-      state,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      state: any,
       action: PayloadAction<ZoomedInPlotState | undefined>
     ) => {
       if (!action.payload) {
@@ -49,14 +50,20 @@ export const webviewSlice = createSlice({
         Object.assign(state.zoomedInPlot, action.payload)
       }
     },
-    updateHasPlots: (state, action: PayloadAction<boolean>) => {
+    updateHasPlots: (
+      state: { hasPlots: boolean },
+      action: PayloadAction<boolean>
+    ) => {
       state.hasPlots = action.payload
     },
-    updateHasSelectedPlots: (state, action: PayloadAction<boolean>) => {
+    updateHasSelectedPlots: (
+      state: { hasSelectedPlots: boolean },
+      action: PayloadAction<boolean>
+    ) => {
       state.hasSelectedPlots = action.payload
     },
     updateSelectedRevisions: (
-      state,
+      state: { selectedRevisions: Revision[] },
       action: PayloadAction<Revision[] | undefined>
     ) => {
       state.selectedRevisions = action.payload || []
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ module.exports = {`
`10`	`10`	`files: ['src/test/*/.test.ts'],`
`11`	`11`	`rules: {`
`12`	`12`	// These aren't jest tests, but still use `expect`
	`13`	`+ 'jest/no-standalone-expect': 'off',`
`13`	`14`	`'jest/valid-expect': 'off',`
`14`	`15`	`'no-unused-expressions': 'off'`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ const addFilterValue = async (path: string, operator: Operator) => {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`return {`
`80`		`- operator: operator,`
	`80`	`+ operator,`
`81`	`81`	`path,`
`82`	`82`	`value`
`83`	`83`	`}`
`@@ -106,7 +106,7 @@ export const pickFilterToAdd = async (`
`106`	`106`
`107`	`107`	`if ([Operator.IS_TRUE, Operator.IS_FALSE].includes(operator)) {`
`108`	`108`	`return {`
`109`		`- operator: operator,`
	`109`	`+ operator,`
`110`	`110`	`path: picked.path,`
`111`	`111`	`value: undefined`
`112`	`112`	`}`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ export class RepositoryModel`
`141`	`141`	`): PathStatus[] {`
`142`	`142`	`return fileOrStage`
`143`	`143`	`.map(entry => (entry as StageOrFileStatuses)?.[ChangedType.CHANGED_OUTS])`
`144`		`- .filter(value => value) as PathStatus[]`
	`144`	`+ .filter(Boolean) as PathStatus[]`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`private collectStatuses(acc: ModifiedAndNotInCache, entry: PathStatus) {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import { extensions } from 'vscode'`
	`2`	`+// eslint-disable-next-line import/default`
`2`	`3`	`import TelemetryReporter from '@vscode/extension-telemetry'`
`3`	`4`	`import { getTelemetryReporter, sendTelemetryEvent } from '.'`
`4`	`5`	`import {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// eslint-disable-next-line import/default`
`1`	`2`	`import TelemetryReporter from '@vscode/extension-telemetry'`
`2`	`3`	`import {`
`3`	`4`	`EXTENSION_ID,`