Fix never ending loading on no experiments data (#4117)

Author: julieg18

extension/src/cli/dvc/contract.ts

@@ -100,7 +100,7 @@ export type ExpWithError = {
 type ExpWithData = {
   rev: string
   name?: string
-  data: ExpData
+  data?: ExpData
 }
 
 export type ExpState = ExpWithData | ExpWithError

extension/src/experiments/columns/collect/index.test.ts

@@ -420,7 +420,7 @@ describe('collectChanges', () => {
     }
 
     expect(changes).toStrictEqual(
-      Object.keys(workspace.data.deps || {})
+      Object.keys(workspace?.data?.deps || {})
         .map(dep => `deps:${dep}`)
         .sort()
     )

extension/src/experiments/columns/collect/index.ts

@@ -101,7 +101,7 @@ export const collectParamsFiles = (
   if (experimentHasError(workspace)) {
     return new Set()
   }
-  const files = Object.keys(workspace.data.params || {})
+  const files = Object.keys(workspace?.data?.params || {})
     .filter(Boolean)
     .map(file => standardizePath(join(dvcRoot, file)))
   return new Set(files)

extension/src/experiments/model/collect.ts

@@ -328,7 +328,7 @@ const hasCheckpoints = (data: ExpShowOutput) => {
     return false
   }
 
-  return !!workspace.data.meta.has_checkpoints
+  return !!workspace?.data?.meta.has_checkpoints
 }
 
 const collectCliError = (

extension/src/test/cli/expShow.test.ts

@@ -45,16 +45,16 @@ suite('exp show --show-json', () => {
           'object'
         )
 
-        expect(commit.data.timestamp, 'should have a timestamp').to.be.a(
+        expect(commit?.data?.timestamp, 'should have a timestamp').to.be.a(
           'string'
         )
 
-        expect(commit.data.params, 'should have params').to.be.an('object')
-        expect(commit.data.metrics, 'should have metrics').to.be.an('object')
+        expect(commit?.data?.params, 'should have params').to.be.an('object')
+        expect(commit?.data?.metrics, 'should have metrics').to.be.an('object')
 
         for (const file of Object.values({
-          ...commit.data.params,
-          ...commit.data.metrics
+          ...commit?.data?.params,
+          ...commit?.data?.metrics
         })) {
           expect(file, 'should have children').to.be.an('object')
           if (fileHasError(file)) {
@@ -64,8 +64,8 @@ suite('exp show --show-json', () => {
           expect(isEmpty(file.data), 'should have data').to.be.false
         }
 
-        expect(commit.data.deps, 'should have deps').to.be.an('object')
-        expect(commit.data.outs, 'should have outs').to.be.an('object')
+        expect(commit?.data?.deps, 'should have deps').to.be.an('object')
+        expect(commit?.data?.outs, 'should have outs').to.be.an('object')
 
         for (const file of Object.values({
           ...commit.data?.deps,

extension/src/test/suite/plots/index.test.ts

@@ -45,7 +45,7 @@ import { isErrorItem } from '../../../tree'
 import { RegisteredCommands } from '../../../commands/external'
 import { REVISIONS } from '../../fixtures/plotsDiff'
 import * as FileSystem from '../../../fileSystem'
-import { experimentHasError } from '../../../cli/dvc/contract'
+import { ExpShowOutput, experimentHasError } from '../../../cli/dvc/contract'
 import { COMMITS_SEPARATOR } from '../../../cli/git/constants'
 
 suite('Plots Test Suite', () => {
@@ -139,7 +139,7 @@ suite('Plots Test Suite', () => {
       bypassProcessManagerDebounce(mockNow)
       void experiments.setState({
         availableNbCommits: { main: 6 },
-        expShow: updatedExpShowFixture,
+        expShow: updatedExpShowFixture as ExpShowOutput,
         gitLog: newCommit + COMMITS_SEPARATOR + gitLogFixture,
         rowOrder: [{ branch: 'main', sha: newCommit }, ...rowOrderFixture]
       })