Skip to content

Commit 4ab0a46

Browse files
authored
Add "(pip)" to setup install button (#4013)
1 parent acfd8f9 commit 4ab0a46

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

webview/src/setup/components/App.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ describe('App', () => {
165165
`DVC & DVCLive can be auto-installed as packages with ${defaultInterpreter}`
166166
)
167167
).toBeInTheDocument()
168-
expect(screen.getByText('Install')).toBeInTheDocument()
168+
expect(screen.getByText('Install (pip)')).toBeInTheDocument()
169169
})
170170

171171
it('should let the user find another Python interpreter to install DVC when the Python extension is not installed', () => {
@@ -215,7 +215,7 @@ describe('App', () => {
215215
pythonBinPath: 'python'
216216
})
217217

218-
const button = screen.getByText('Install')
218+
const button = screen.getByText('Install (pip)')
219219
fireEvent.click(button)
220220

221221
expect(mockPostMessage).toHaveBeenCalledWith({

webview/src/setup/components/dvc/CliUnavailable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export const CliUnavailable: React.FC<PropsWithChildren> = ({ children }) => {
1818
DVC & DVCLive can be auto-installed as packages with {pythonBinPath}
1919
</p>
2020
<div className={styles.sideBySideButtons}>
21-
<Button onClick={installDvc} text="Install" />
21+
<Button onClick={installDvc} text="Install (pip)" />
2222
<Button onClick={setupWorkspace} text="Configure" />
2323
</div>
2424
</>

webview/src/stories/Setup.stories.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ CompletedConnected.args = getUpdatedArgs({
9898
shareLiveToStudio: true
9999
})
100100

101-
export const NoCLIPythonNotFound = Template.bind({})
102-
NoCLIPythonNotFound.args = getUpdatedArgs({
101+
export const CLIPythonNotFound = Template.bind({})
102+
CLIPythonNotFound.args = getUpdatedArgs({
103103
cliCompatible: undefined,
104104
dvcCliDetails: {
105105
command: 'dvc',
@@ -109,8 +109,8 @@ NoCLIPythonNotFound.args = getUpdatedArgs({
109109
pythonBinPath: undefined
110110
})
111111

112-
export const NoCLIPythonFound = Template.bind({})
113-
NoCLIPythonFound.args = getUpdatedArgs({
112+
export const CLIPythonFound = Template.bind({})
113+
CLIPythonFound.args = getUpdatedArgs({
114114
cliCompatible: undefined,
115115
dvcCliDetails: {
116116
command: '/opt/homebrew/Caskroom/miniforge/base/bin/python -m dvc',

0 commit comments

Comments
 (0)