Fix warnings produced by integration tests (#3728)

Author: mattseddon

extension/src/test/suite/experiments/data/index.test.ts

@@ -98,8 +98,9 @@ suite('Experiments Data Test Suite', () => {
           disposable.track(new EventEmitter<boolean>()),
           {
             getIsBranchesView: () => false,
-            getNbOfCommitsToShow: () => DEFAULT_NUM_OF_COMMITS_TO_SHOW
-          } as ExperimentsModel
+            getNbOfCommitsToShow: () => DEFAULT_NUM_OF_COMMITS_TO_SHOW,
+            setAvailableBranchesToShow: stub()
+          } as unknown as ExperimentsModel
         )
       )
 
@@ -151,8 +152,9 @@ suite('Experiments Data Test Suite', () => {
           disposable.track(new EventEmitter<boolean>()),
           {
             getIsBranchesView: () => false,
-            getNbOfCommitsToShow: () => DEFAULT_NUM_OF_COMMITS_TO_SHOW
-          } as ExperimentsModel
+            getNbOfCommitsToShow: () => DEFAULT_NUM_OF_COMMITS_TO_SHOW,
+            setAvailableBranchesToShow: stub()
+          } as unknown as ExperimentsModel
         )
       )
 

extension/src/test/suite/experiments/util.ts

@@ -200,8 +200,9 @@ export const buildExperimentsData = (disposer: SafeWatcherDisposer) => {
       disposer.track(new EventEmitter<boolean>()),
       {
         getIsBranchesView: () => false,
-        getNbOfCommitsToShow: () => DEFAULT_NUM_OF_COMMITS_TO_SHOW
-      } as ExperimentsModel
+        getNbOfCommitsToShow: () => DEFAULT_NUM_OF_COMMITS_TO_SHOW,
+        setAvailableBranchesToShow: stub()
+      } as unknown as ExperimentsModel
     )
   )
 

extension/src/test/suite/vscode/walkthrough.test.ts

@@ -1,7 +1,7 @@
 import { afterEach, beforeEach, describe, it, suite } from 'mocha'
 import { expect } from 'chai'
 import { commands } from 'vscode'
-import { restore, spy } from 'sinon'
+import { restore, stub } from 'sinon'
 import { closeAllEditors } from '../util'
 import { RegisteredCommands } from '../../../commands/external'
 
@@ -16,14 +16,19 @@ suite('Walkthrough Test Suite', () => {
 
   describe('dvc.getStarted', () => {
     it('should be able to show the walkthrough', async () => {
-      const executeCommandSpy = spy(commands, 'executeCommand')
+      const mockExecuteCommand = stub(commands, 'executeCommand')
+      mockExecuteCommand
+        .onFirstCall()
+        .callsFake((...args) => mockExecuteCommand.wrappedMethod(...args))
+        .onSecondCall()
+        .resolves(undefined)
 
       await expect(
         commands.executeCommand(RegisteredCommands.EXTENSION_GET_STARTED)
       ).to.be.eventually.equal(undefined)
 
-      expect(executeCommandSpy).to.be.calledTwice
-      expect(executeCommandSpy).to.be.calledWith(
+      expect(mockExecuteCommand).to.be.calledTwice
+      expect(mockExecuteCommand).to.be.calledWith(
         'workbench.action.openWalkthrough',
         'iterative.dvc#welcome'
       )