Fix filtering and add missing experiments on quick pick experiment selection (#3056)

* Allow filtering by description/detail on quick pick exp selection
* Add missing experiments on "Modify Experiment Param(s) and ..." commands

Author: julieg18

extension/src/experiments/index.ts

@@ -593,7 +593,7 @@ export class Experiments extends BaseRepository<TableData> {
     }
 
     const experiment = await pickExperiment(
-      this.experiments.getExperiments(),
+      this.experiments.getAllExperiments(),
       Title.SELECT_BASE_EXPERIMENT
     )
 

extension/src/experiments/model/quickPick.test.ts

@@ -70,7 +70,8 @@ describe('pickExperiments', () => {
         }
       ],
       MAX_SELECTED_EXPERIMENTS,
-      Title.SELECT_EXPERIMENTS
+      Title.SELECT_EXPERIMENTS,
+      { matchOnDescription: true, matchOnDetail: true }
     )
   })
 
@@ -162,7 +163,8 @@ describe('pickExperiments', () => {
       ],
       [],
       MAX_SELECTED_EXPERIMENTS,
-      Title.SELECT_EXPERIMENTS
+      Title.SELECT_EXPERIMENTS,
+      { matchOnDescription: true, matchOnDetail: true }
     )
   })
 
@@ -250,7 +252,8 @@ describe('pickExperiments', () => {
       ],
       [getExpectedItem(selectedCheckpoint)],
       MAX_SELECTED_EXPERIMENTS,
-      Title.SELECT_EXPERIMENTS
+      Title.SELECT_EXPERIMENTS,
+      { matchOnDescription: true, matchOnDetail: true }
     )
   })
 })

extension/src/experiments/model/quickPicks.ts

@@ -135,6 +135,7 @@ export const pickExperiments = (
     items,
     selectedItems,
     MAX_SELECTED_EXPERIMENTS,
-    Title.SELECT_EXPERIMENTS
+    Title.SELECT_EXPERIMENTS,
+    { matchOnDescription: true, matchOnDetail: true }
   )
 }

extension/src/experiments/quickPick.ts

@@ -21,7 +21,7 @@ export const pickExperiment = (
         label,
         value: { id, name: name || label }
       })),
-      { title }
+      { matchOnDescription: true, matchOnDetail: true, title }
     )
   }
 }

extension/src/test/suite/experiments/workspace.test.ts

@@ -530,6 +530,8 @@ suite('Workspace Experiments Test Suite', () => {
         ],
         {
           canPickMany: false,
+          matchOnDescription: true,
+          matchOnDetail: true,
           title: Title.SELECT_EXPERIMENT
         }
       )

extension/src/vscode/quickPick.ts

@@ -45,13 +45,21 @@ export const quickPickOne = (
 const createQuickPick = <T>(
   items: readonly QuickPickItemWithValue<T>[],
   selectedItems: readonly QuickPickItemWithValue<T>[] | undefined,
-  options: { canSelectMany: boolean; placeholder?: string; title: Title }
+  options: {
+    canSelectMany: boolean
+    placeholder?: string
+    title: Title
+    matchOnDescription?: boolean
+    matchOnDetail?: boolean
+  }
 ): QuickPick<QuickPickItemWithValue<T>> => {
   const quickPick = window.createQuickPick<QuickPickItemWithValue<T>>()
 
   quickPick.canSelectMany = options.canSelectMany
   quickPick.placeholder = options.placeholder
   quickPick.title = options.title
+  quickPick.matchOnDescription = options.matchOnDescription || false
+  quickPick.matchOnDetail = options.matchOnDetail || false
 
   quickPick.items = items
   if (selectedItems) {
@@ -181,12 +189,14 @@ export const quickPickLimitedValues = <T>(
   items: QuickPickItemWithValue<T>[],
   selectedItems: readonly QuickPickItemWithValue<T>[],
   maxSelectedItems: number,
-  title: Title
+  title: Title,
+  options?: { matchOnDescription?: boolean; matchOnDetail?: boolean }
 ): Promise<Exclude<T, undefined>[] | undefined> =>
   new Promise(resolve => {
     const quickPick = createQuickPick(items, selectedItems, {
       canSelectMany: true,
-      title
+      title,
+      ...options
     })
 
     limitSelected<T>(quickPick, maxSelectedItems)