Bypass filters on missing values (for queued experiments) (#1732)

* add logic into filter to bypass undefined (for queued experiments)

* fix auto apply filter behaviour

Author: mattseddon

extension/src/experiments/index.ts

@@ -252,7 +252,9 @@ export class Experiments extends BaseRepository<TableData> {
     this.experiments.setSelectionMode(useFilters)
 
     if (useFilters) {
-      const filteredExperiments = this.experiments.getFilteredExperiments()
+      const filteredExperiments = this.experiments
+        .getFilteredExperiments()
+        .filter(exp => !exp.queued)
       if (tooManySelected(filteredExperiments)) {
         await this.warnAndDoNotAutoApply(filteredExperiments)
       } else {

extension/src/experiments/model/filterBy/index.test.ts

@@ -31,13 +31,40 @@ describe('filterExperiments', () => {
       id: 3,
       params: {
         'params.yaml': {
+          bool: null,
           filter: 3,
-          sort: 1
+          sort: 1,
+          text: 'not missing'
         }
       }
     }
   ] as unknown as Experiment[]
 
+  it('should not filter experiments if they do not have the provided value (for queued experiments)', () => {
+    const unfilteredQueuedExperiments = filterExperiments(
+      [
+        {
+          operator: Operator.IS_FALSE,
+          path: joinColumnPath(ColumnType.METRICS, 'metrics.json', 'acc'),
+          value: undefined
+        }
+      ],
+      experiments
+    )
+
+    expect(
+      experiments
+        .map(
+          experiment => experiment[ColumnType.METRICS]?.['metrics.json']?.acc
+        )
+        .filter(Boolean)
+    ).toHaveLength(0)
+
+    expect(
+      unfilteredQueuedExperiments.map(experiment => experiment.id)
+    ).toStrictEqual([1, 2, 3])
+  })
+
   it('should return the original experiments if no filters are provided', () => {
     const unFilteredExperiments = filterExperiments([], experiments)
     expect(unFilteredExperiments).toStrictEqual(experiments)

extension/src/experiments/model/filterBy/index.ts

@@ -45,6 +45,9 @@ const evaluate = <T>(
   operator: Operator,
   filterValue: T
 ): boolean => {
+  if (valueToEvaluate === undefined) {
+    return true
+  }
   switch (operator) {
     case Operator.GREATER_THAN:
       return valueToEvaluate > filterValue

extension/src/test/suite/experiments/model/filterBy/tree.test.ts

@@ -37,6 +37,7 @@ suite('Experiments Filter By Tree Test Suite', () => {
     disposable.dispose()
   })
 
+  // eslint-disable-next-line sonarjs/cognitive-complexity
   describe('ExperimentsFilterByTree', () => {
     it('should appear in the UI', async () => {
       await expect(
@@ -80,15 +81,26 @@ suite('Experiments Filter By Tree Test Suite', () => {
           subRows: main.subRows
             ?.filter(experiment => {
               const accuracy = experiment.metrics?.['summary.json']?.accuracy
-              return accuracy && accuracy >= 0.45
+              return !!(
+                accuracy === undefined ||
+                (accuracy && accuracy >= 0.45)
+              )
             })
-            .map(experiment => ({
-              ...experiment,
-              subRows: experiment.subRows?.filter(checkpoint => {
-                const accuracy = checkpoint.metrics?.['summary.json']?.accuracy
-                return accuracy && accuracy >= 0.45
-              })
-            }))
+            .map(experiment =>
+              experiment.queued
+                ? experiment
+                : {
+                    ...experiment,
+                    subRows: experiment.subRows?.filter(checkpoint => {
+                      const accuracy =
+                        checkpoint.metrics?.['summary.json']?.accuracy
+                      return !!(
+                        accuracy === undefined ||
+                        (accuracy && accuracy >= 0.45)
+                      )
+                    })
+                  }
+            )
         }
       ]